Date: Sun, 25 Nov 2012 20:29:11 +0100 From: Attilio Rao <attilio@freebsd.org> To: Andriy Gapon <avg@freebsd.org> Cc: freebsd-hackers@freebsd.org, Ryan Stone <rysto32@gmail.com> Subject: Re: stop_cpus_hard when multiple CPUs are panicking from an NMI Message-ID: <CAJ-FndAw3QP3S_n_p_HAdOnxVHgeS0O2wjua9KZRJtMwXTYrkA@mail.gmail.com> In-Reply-To: <50B26179.4040205@FreeBSD.org> References: <CAFMmRNwb_rxYXHGtXgtcyVUJnFDx5PSeMmA_crBbeV_rtzL9Cg@mail.gmail.com> <50A5F12C.1050902@FreeBSD.org> <CAJ-FndAB%2B7KRAE91L9634eXgzqgrizwtwCBC7AAg%2B0EX89TEBQ@mail.gmail.com> <50A63D1D.9090500@FreeBSD.org> <CAJ-FndDC1QCytXDJqVkism_5VoLNo_OzZxNEQ9NHx63HC=GTNg@mail.gmail.com> <50A65208.4050804@FreeBSD.org> <CAJ-FndADxJtYPX2-cQnqJoLhzYtJMidG1DPPY%2B6Dtf4rVw_zrw@mail.gmail.com> <50B21545.5060807@FreeBSD.org> <CAJ-FndDVt8VRA4kQipT5Lm%2Bo2KRRum9NKWorfeAucwR=hJ0uDw@mail.gmail.com> <50B22DA0.9080207@FreeBSD.org> <CAJ-FndA5SfW7EXLX8DQezYPxBeavv0ET%2BfTMj%2BPhsQhnKK=X9g@mail.gmail.com> <50B26179.4040205@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Nov 25, 2012 at 7:20 PM, Andriy Gapon <avg@freebsd.org> wrote: > on 25/11/2012 20:05 Attilio Rao said the following: >> If you really want to do something like that please rename >> s/generic_stop_cpus/generic_stop_butself() or similar convention and I >> may be not opposed to it. > > As we discussed before, anything else besides "all but self" does not make > sense. So I am not sure what's the point of being that verbose in the naming. Avoid POLA violation and show there is a change in the KPI? I'd personally prefer a new name, but I'm open on not getting it. Attilio -- Peace can only be achieved by understanding - A. Einstein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-FndAw3QP3S_n_p_HAdOnxVHgeS0O2wjua9KZRJtMwXTYrkA>