From owner-svn-ports-head@FreeBSD.ORG Wed Apr 29 09:25:35 2015 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1602767D; Wed, 29 Apr 2015 09:25:35 +0000 (UTC) Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E1FC313CC; Wed, 29 Apr 2015 09:25:34 +0000 (UTC) Received: from [192.168.1.22] (140.Red-83-60-172.dynamicIP.rima-tde.net [83.60.172.140]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by shepard.synsport.net (Postfix) with ESMTP id 40ED643BDF; Wed, 29 Apr 2015 04:25:30 -0500 (CDT) Message-ID: <5540A388.5070005@marino.st> Date: Wed, 29 Apr 2015 11:25:28 +0200 From: John Marino Reply-To: marino@freebsd.org, marino@freebsd.org User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Gerald Pfeifer , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r384521 - head/Mk References: <201504222129.t3MLTLut046445@svn.freebsd.org> <5538D221.2090804@marino.st> In-Reply-To: <5538D221.2090804@marino.st> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Apr 2015 09:25:35 -0000 On 4/23/2015 13:06, John Marino wrote: > On 4/22/2015 23:29, Gerald Pfeifer wrote: >> Author: gerald >> Date: Wed Apr 22 21:29:21 2015 >> New Revision: 384521 >> URL: https://svnweb.freebsd.org/changeset/ports/384521 >> >> Log: >> Since there is not going to be any new version of GCC in the FreeBSD >> base system ever again, simplify the GCCVERSION table and logic to not >> worry about minimum system versions carrying a certain version of GCC. >> >> This also removes the _GCCVERSION_${v}_R variables and simplifies some >> logic and debug output. >> >> Modified: >> head/Mk/bsd.gcc.mk >> > > This look like "for fun" change, like several before it on bsd.gcc.mk. > This is the most heavily patched Mk file for dports and most changes to > it break dports. DragonFly does indeed have GCC in base (two of them > actually) and probably will for a long time to come. > > I have not access the impacts yet, but this might be a sledgehammer to > recover from. In the future, could you at least give me a heads up and > ideally put me on a phabric review for changes to anything compiler > related? In general, shouldn't bsd.gcc.mk go through a phabric review > anyway? > > Thanks. I've been silently adjusting and not all the changes actually > did anything except "simplify". > Hi Gerald, To follow up on this topic, I realized the situation was not sustainable. I wrote a replacement file called bsd.df.gcc.mk which gets pulled in by bsd.port.mk instead of bsd.gcc.mk on DPorts. As a bonus, the makefile "code" is much clearer than bsd.gcc.mk and it's easy for me to maintain (and basically static). TLDR: DPorts doesn't use bsd.gcc.mk anymore, you can do what you want with it without asking if it breaks DragonFly. Thanks, John