Date: Tue, 29 Jul 2008 23:06:26 +0200 From: Kris Kennaway <kris@FreeBSD.org> To: Freddie Cash <fjwcash@gmail.com> Cc: freebsd-ports@freebsd.org Subject: Re: Mk/bsd.openssl.mk optimization Message-ID: <488F8652.9040304@FreeBSD.org> In-Reply-To: <200807291254.38033.fjwcash@gmail.com> References: <op.ueqfl1xy0g54sc@localhost> <op.ue17xeex0g54sc@localhost> <op.ue2j4tv60g54sc@localhost> <200807291254.38033.fjwcash@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Freddie Cash wrote:
> On July 29, 2008 12:52 pm V.Chukharev wrote:
>> Another patch, just one line. It can be applied independently from the
>> patch for bsd.port.subdir.mk.
>>
>> =============
>> --- /usr/ports/Mk/bsd.openssl.mk.orig 2008-07-23 09:14:29.000000000
>> +0300 +++ /usr/ports/Mk/bsd.openssl.mk 2008-07-29 20:35:05.000000000
>> +0300 @@ -121,7 +121,7 @@
>> exists(${DESTDIR}/${LOCALBASE}/lib/libcrypto.so)
>> # find installed port and use it for dependency
>> PKG_DBDIR?= ${DESTDIR}/var/db/pkg
>> -OPENSSL_INSTALLED!= grep -l -r "^lib/libssl.so." "${PKG_DBDIR}" | \
>> +OPENSSL_INSTALLED!= find "${PKG_DBDIR}" -type f -name "+CONTENTS"
>> -print0 | xargs -0 grep -l "^lib/libssl.so." | \ while read contents;
>
> Is piping this into xargs faster/better than using -exec option to find?
>
> find "${PKG_DBDIR}" -type f -name "+CONTENTS" -exec \
> grep -l "^lib/libssl.so." {} \;
>
You guys are still just going for the small improvements - there's no
need to compute this 19000 times since it won't change during the course
of an index build or similar global-recursive target.
Kris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?488F8652.9040304>