From owner-freebsd-current@FreeBSD.ORG Fri Aug 14 16:57:54 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AE715106568E; Fri, 14 Aug 2009 16:57:54 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 7F19D8FC45; Fri, 14 Aug 2009 16:57:54 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 2CEE546B35; Fri, 14 Aug 2009 12:57:54 -0400 (EDT) Received: from jhbbsd.hudson-trading.com (unknown [209.249.190.8]) by bigwig.baldwin.cx (Postfix) with ESMTPA id 4776D8A0AD; Fri, 14 Aug 2009 12:57:53 -0400 (EDT) From: John Baldwin To: Tim Kientzle Date: Fri, 14 Aug 2009 12:57:42 -0400 User-Agent: KMail/1.9.7 References: <200903282317.n2SNHIjI015202@svn.freebsd.org> <200908141004.09354.jhb@freebsd.org> <4A8583DB.1090507@freebsd.org> In-Reply-To: <4A8583DB.1090507@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200908141257.42672.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Fri, 14 Aug 2009 12:57:53 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.5 required=4.2 tests=AWL,BAYES_00,RDNS_NONE autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: "Bjoern A. Zeeb" , freebsd-current@freebsd.org, Doug Barton Subject: Re: svn commit: r190514 - head/sys/conf X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Aug 2009 16:57:54 -0000 On Friday 14 August 2009 11:33:47 am Tim Kientzle wrote: > John Baldwin wrote: > > On Thursday 13 August 2009 2:57:10 pm Doug Barton wrote: > >> Bjoern A. Zeeb wrote: > >>> Author: bz > >>> Date: Sat Mar 28 23:17:18 2009 > >>> New Revision: 190514 > >>> URL: http://svn.freebsd.org/changeset/base/190514 > >>> > >>> Log: > >>> For kernel builds reduce the impact of svnversion, just scanning > >>> src/sys and not the entire src/ tree. > > Performance here I think is a red herring. This is > really about correctness: The SVN revision of usr.bin/ls > simply isn't relevant for the kernel build. Very true. > >> Also, what problem are we really trying to solve here? With a > >> populated cache it takes on average 5 seconds to run all of src, and > >> just under 1 to do only sys. Is 4 seconds really that important to > >> save? With a dry cache I'm sure it takes a little longer, but has > >> anyone actually measured this? > > I just measured over 30 seconds for svnversion against /usr/src and > around 6 for /usr/src/sys (both with cold cache). > > > It takes far longer than 5 seconds here against a local SVN repo over NFS. > > The repo has nothing to do with it. svnversion doesn't > talk to the repo. It only examines the working copy. Ah, true. My checkouts are also over NFS though rather than local disk which may explain it still. -- John Baldwin