From owner-svn-src-all@FreeBSD.ORG Thu Feb 19 01:24:07 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9344D559 for ; Thu, 19 Feb 2015 01:24:07 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 57FDE189 for ; Thu, 19 Feb 2015 01:24:07 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.9/8.14.9) with ESMTP id t1J1O7LA030438 for ; Thu, 19 Feb 2015 01:24:07 GMT (envelope-from bdrewery@freefall.freebsd.org) Received: (from bdrewery@localhost) by freefall.freebsd.org (8.14.9/8.14.9/Submit) id t1J1O7xU030435 for svn-src-all@freebsd.org; Thu, 19 Feb 2015 01:24:07 GMT (envelope-from bdrewery) Received: (qmail 62349 invoked from network); 18 Feb 2015 19:24:02 -0600 Received: from unknown (HELO ?10.10.1.139?) (freebsd@shatow.net@10.10.1.139) by sweb.xzibition.com with ESMTPA; 18 Feb 2015 19:24:02 -0600 Message-ID: <54E53B34.5070605@FreeBSD.org> Date: Wed, 18 Feb 2015 19:24:04 -0600 From: Bryan Drewery Organization: FreeBSD User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Bruce Evans Subject: Re: svn commit: r278889 - head/lib/libc/include References: <201502170854.t1H8s4TL085174@svn.freebsd.org> <54E52019.8080009@FreeBSD.org> <20150219113226.K2984@besplex.bde.org> In-Reply-To: <20150219113226.K2984@besplex.bde.org> OpenPGP: id=6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="coaBkDreXFxRaNXll2iG82XBNptxFfnbj" Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Konstantin Belousov X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Feb 2015 01:24:07 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --coaBkDreXFxRaNXll2iG82XBNptxFfnbj Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 2/18/2015 6:58 PM, Bruce Evans wrote: > On Wed, 18 Feb 2015, Bryan Drewery wrote: >=20 >> On 2/17/2015 2:54 AM, Konstantin Belousov wrote: >>> ... >>> Log: >>> Restore the extern qualifier on __cleanup. >>> ... >>> Modified: head/lib/libc/include/libc_private.h >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D >>> >>> --- head/lib/libc/include/libc_private.h Tue Feb 17 08:50:26 >>> 2015 (r278888) >>> +++ head/lib/libc/include/libc_private.h Tue Feb 17 08:54:03 >>> 2015 (r278889) >>> @@ -271,7 +271,7 @@ void _malloc_first_thread(void); >>> /* >>> * Function to clean up streams, called from abort() and exit(). >>> */ >>> -void (*__cleanup)(void) __hidden; >>> +extern void (*__cleanup)(void) __hidden; >>> >>> /* >>> * Get kern.osreldate to detect ABI revisions. Explicitly >>> >> >> Is this a NOP? >=20 > No, since this is a data declaration. It would be a style bug on a > prototype. Ah, of course. I missed the *, despite the (). --=20 Regards, Bryan Drewery --coaBkDreXFxRaNXll2iG82XBNptxFfnbj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJU5Ts0AAoJEDXXcbtuRpfP3w8H/0+okgPyrG4pqke1nZjr91nj bbWN9YrIAYMyrbRFsV4CtkOuf10bbymFo/BnH+obaWYyUrrozaH77LH1ojuMHUl2 bx5omR8S7wwp18YqxZBDHuMCQRsZb6G3qEFJtSWaNsmHMsEtowleqyQpyWZ3yeFG GkR+K1y24mFrvN6N/Y+QyE5WaAz35aIZ1wkdlad9MXfMHif087O5p90YOcBc7/lc DHGfEAJ1AgwmPx23JuL1wUtwVNP1wvP+ACmDLjEAWUNlzqfKAEFpUJi2G8jzUujn mLrrfx8zJJbufdfSbP+Ve8xjmLqnzRJAL2frzMfuj3Sf9fZeS3ekCtLLbbA5Vn8= =129k -----END PGP SIGNATURE----- --coaBkDreXFxRaNXll2iG82XBNptxFfnbj--