Date: Sat, 28 Sep 2024 09:48:16 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 281496] devel/olm: fix build with clang 19 Message-ID: <bug-281496-7788-mdTYc1kuVv@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-281496-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-281496-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D281496 --- Comment #2 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=3Dc42de78032ea24d6431412e2aec3538= 3c3c66a34 commit c42de78032ea24d6431412e2aec35383c3c66a34 Author: Dimitry Andric <dim@FreeBSD.org> AuthorDate: 2024-09-14 11:33:09 +0000 Commit: Dimitry Andric <dim@FreeBSD.org> CommitDate: 2024-09-28 09:46:34 +0000 security/olm: fix build with clang 19 Clang 19 has become more strict about assigning to const variables, resulting in an error similar to: =20=20=20=20=20 /wrkdirs/usr/ports/security/olm/work/olm-6d767aaf29bdf15571c2ef4d3f8f9e953d= e03733/include/olm/list.hh:106:13: error: cannot assign to variable 'other_pos' with const-qualified type 'T *const' 106 | ++other_pos; | ^ ~~~~~~~~~ =20=20=20=20=20 /wrkdirs/usr/ports/security/olm/work/olm-6d767aaf29bdf15571c2ef4d3f8f9e953d= e03733/include/olm/list.hh:102:19: note: variable 'other_pos' declared const here 102 | T * const other_pos =3D other._data; | ~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~ In this case, it looks like a typo: "T * const" means that the pointer itself is const, thus it cannot be incremented. Instead, this should be "T const *" (spelled alternatively as "const T *"), which means that the object pointed to is const, not the pointer itself. PR: 281496 Approved by: maintainer timeout (2 weeks) MFH: 2024Q3 security/olm/files/patch-include_olm_list.hh (new) | 11 +++++++++++ 1 file changed, 11 insertions(+) --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-281496-7788-mdTYc1kuVv>