Date: Wed, 26 Jul 2017 10:52:52 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: Jose Alonso Cardenas Marquez <acm@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r446552 - head/devel/dcd-server Message-ID: <20170726105252.GC35824@FreeBSD.org> In-Reply-To: <c408fe59-8574-884c-3efb-4ff9ffcb0949@FreeBSD.org> References: <201707250144.v6P1isvV008488@repo.freebsd.org> <d2532ad7-fe6a-11cb-eb25-8146f35ca5ba@FreeBSD.org> <20170726070112.GA35824@FreeBSD.org> <e5571e27-afda-2786-8f4a-5e0aba07c710@FreeBSD.org> <20170726103915.GB35824@FreeBSD.org> <c408fe59-8574-884c-3efb-4ff9ffcb0949@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jul 26, 2017 at 12:45:38PM +0200, Mathieu Arnold wrote: > Le 26/07/2017 ?? 12:39, Alexey Dokuchaev a ??crit : > > On Wed, Jul 26, 2017 at 12:22:45PM +0200, Mathieu Arnold wrote: > >> Le 26/07/2017 ?? 09:01, Alexey Dokuchaev a ??crit : > >>> On Wed, Jul 26, 2017 at 12:36:01AM +0200, Mathieu Arnold wrote: > >>>> Le 25/07/2017 ?? 03:44, Jose Alonso Cardenas Marquez a ??crit : > >>>>> New Revision: 446552 > >>>>> URL: https://svnweb.freebsd.org/changeset/ports/446552 > >>>>> > >>>>> Log: > >>>>> - Add pkg-plist forgotten on previous commit > >>>> You need to bump PORTREVISION so that the package is rebuilt with > >>>> the plist. > >>> Why would it get packaged without (with an empty) plist? > >> What are metaports? > > "Abstract" ports that don't install things on their own but pull a set of > > dependencies? How's it relevant to `devel/dcd-server', unless I'm missing > > something? > > I guess Jeopardy! is not that a universal thing. ENOPARSE, sorry. > A port without a plist is perfectly valid, it will get build, and > packaged just fine. The framework cannot know that you forgot to commit > the plist. So if you commit a port and forget the plist, it will get > built and the package will have dependencies, and no files. If you then > add the plist later, the framework cannot know that the package it built > earlier needs to be rebuilt because it has files now, so PORTREVISION > needs to be bumped. Shouldn't `check-plist' kick in and packaging fail due to untracked files being installed and plist forgotten? ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170726105252.GC35824>