From owner-svn-src-all@FreeBSD.ORG Sun Mar 15 15:57:42 2009 Return-Path: Delivered-To: svn-src-all@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D4A88106571D; Sun, 15 Mar 2009 15:57:42 +0000 (UTC) (envelope-from das@FreeBSD.ORG) Received: from zim.MIT.EDU (ZIM.MIT.EDU [18.95.3.101]) by mx1.freebsd.org (Postfix) with ESMTP id 8FB978FC15; Sun, 15 Mar 2009 15:57:42 +0000 (UTC) (envelope-from das@FreeBSD.ORG) Received: from zim.MIT.EDU (localhost [127.0.0.1]) by zim.MIT.EDU (8.14.3/8.14.2) with ESMTP id n2FFwFfZ056834; Sun, 15 Mar 2009 11:58:15 -0400 (EDT) (envelope-from das@FreeBSD.ORG) Received: (from das@localhost) by zim.MIT.EDU (8.14.3/8.14.2/Submit) id n2FFwF7B056833; Sun, 15 Mar 2009 11:58:15 -0400 (EDT) (envelope-from das@FreeBSD.ORG) Date: Sun, 15 Mar 2009 11:58:14 -0400 From: David Schultz To: Roman Divacky Message-ID: <20090315155814.GA56735@zim.MIT.EDU> Mail-Followup-To: Roman Divacky , src-committers@FreeBSD.ORG, svn-src-all@FreeBSD.ORG, svn-src-head@FreeBSD.ORG References: <200903141936.n2EJaDM5006130@svn.freebsd.org> <20090315081240.GB39715@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090315081240.GB39715@freebsd.org> Cc: svn-src-head@FreeBSD.ORG, svn-src-all@FreeBSD.ORG, src-committers@FreeBSD.ORG Subject: Re: svn commit: r189824 - in head/contrib/gcc: . doc X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Mar 2009 15:57:43 -0000 On Sun, Mar 15, 2009, Roman Divacky wrote: > On Sat, Mar 14, 2009 at 07:36:13PM +0000, David Schultz wrote: > > Author: das > > Date: Sat Mar 14 19:36:13 2009 > > New Revision: 189824 > > URL: http://svn.freebsd.org/changeset/base/189824 > > > > Log: > > Make gcc use C99 inline semantics in c99 and gnu99 mode. This was the > > original intent, but the functionality wasn't implemented until after > > gcc 4.2 was released. However, if you compiled a program that would > > behave differently before and after this change, gcc 4.2 would have > > warned you; hence, everything currently in the base system is > > unaffected by this change. This patch also adds additional warnings > > about certain inline function-related bogosity, e.g., using a > > static non-const local variable in an inline function. > > > > These changes were merged from a snapshot of gcc mainline from March > > 2007, prior to the GPLv3 switch. I then ran the regression test suite > > from a more recent gcc snapshot and fixed the important bugs it found. > > I also squelched the following warning unless -pedantic is specified: > > > > foo is static but used in inline function bar which is not static > > > > This is consistent with LLVM's behavior, but not consistent with gcc 4.3. > > thnx a lot for doing this! just a quick question - what is the fallback > strategy for ports that will die on this? It depends, but the compiler option -fgnu89-inline (supported in gcc 4.2+) should do the trick.