From owner-svn-ports-all@freebsd.org Wed Nov 29 06:51:29 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BDCB6DFB069; Wed, 29 Nov 2017 06:51:29 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9E340686E4; Wed, 29 Nov 2017 06:51:29 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id CCD98CE97; Wed, 29 Nov 2017 06:51:28 +0000 (UTC) Date: Wed, 29 Nov 2017 06:51:28 +0000 From: Alexey Dokuchaev To: Yuri Victorovich Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r455079 - in head/net-im/ricochet: . files Message-ID: <20171129065128.GA71839@FreeBSD.org> References: <201711282137.vASLbFPV093863@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201711282137.vASLbFPV093863@repo.freebsd.org> User-Agent: Mutt/1.9.1 (2017-09-22) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Nov 2017 06:51:29 -0000 On Tue, Nov 28, 2017 at 09:37:15PM +0000, Yuri Victorovich wrote: > Author: yuri > Date: Tue Nov 28 21:37:15 2017 > New Revision: 455079 > URL: https://svnweb.freebsd.org/changeset/ports/455079 > > Log: > net-im/ricochet: Unbroke the build. ${OPENSSLDIR}/include coflicted with the STL headers logic; Fixed order (On an unrelated note: could you please wrap your commit logs so they fit 80-char displays? Thank you.) > -OPTIONS_DEFINE= TOR > -OPTIONS_DEFAULT= TOR > -TOR_DESC= Install Tor: it is required for ${PORTNAME} to run > - > USES= compiler:c++11-lib gmake pkgconfig qmake ssl > USE_GITHUB= yes > GH_ACCOUNT= ricochet-im > @@ -29,17 +25,19 @@ USE_QT5= core gui multimedia network qml quick quickco > USE_GL= gl > QMAKE_ARGS+= DEFINES+=RICOCHET_NO_PORTABLE OPENSSLDIR=${OPENSSLBASE} > > +OPTIONS_DEFINE= TOR > +OPTIONS_DEFAULT= TOR > +TOR_DESC= Install Tor: it is required for ${PORTNAME} to run > + > +TOR_RUN_DEPENDS= tor:security/tor I don't get it: if Tor is *required* for ${PORTNAME} to run (per TOR_DESC), why not simply remove the option and use normal RUN_DEPENDS? If it, under some circumstances, is *not required* to run, then TOR_DESC should be reworded. Now it is just plain confusing. ./danfe