From owner-freebsd-fs@FreeBSD.ORG Mon Feb 4 05:05:03 2013 Return-Path: Delivered-To: freebsd-fs@FreeBSD.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 3CC50351; Mon, 4 Feb 2013 05:05:03 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail03.syd.optusnet.com.au (mail03.syd.optusnet.com.au [211.29.132.184]) by mx1.freebsd.org (Postfix) with ESMTP id C2CA5D58; Mon, 4 Feb 2013 05:05:02 +0000 (UTC) Received: from c211-30-173-106.carlnfd1.nsw.optusnet.com.au (c211-30-173-106.carlnfd1.nsw.optusnet.com.au [211.30.173.106]) by mail03.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id r1454nm5030756 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 4 Feb 2013 16:04:52 +1100 Date: Mon, 4 Feb 2013 16:04:49 +1100 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: Pedro Giffuni Subject: Re: svn commit: r246289 - head/sys/ufs/ffs In-Reply-To: <1359945154.62069.YahooMailNeo@web162105.mail.bf1.yahoo.com> Message-ID: <20130204155554.I932@besplex.bde.org> References: <201302031716.r13HGXNP060303@svn.freebsd.org> <510E9D47.2030403@FreeBSD.org> <20130204062149.U2673@besplex.bde.org> <1359945154.62069.YahooMailNeo@web162105.mail.bf1.yahoo.com> MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="0-874308365-1359954289=:932" X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.0 cv=RbTIkCRv c=1 sm=1 a=3vEzreLPZ8cA:10 a=PO7r1zJSAAAA:8 a=JzwRw_2MAAAA:8 a=Nw6HGA-A-RMA:10 a=HxwSwiba8RqU5nfzRA0A:9 a=45ClL6m2LaAA:10 a=TEtd8y5WR3g2ypngnwZWYw==:117 Cc: "freebsd-fs@freebsd.org" , Andriy Gapon , Kirk McKusick X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Feb 2013 05:05:03 -0000 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --0-874308365-1359954289=:932 Content-Type: TEXT/PLAIN; charset=X-UNKNOWN; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE On Sun, 3 Feb 2013, Pedro Giffuni wrote: > (Moving the discussion to freebsd-fs) >> Da: Bruce Evans=A0 >> > ... >>> Just a note that clang actually warned about this one. >>> It has a few more similar warnings for ufs/ffs code. >> >> I wondered how the DIP macro hid the warning. >> =A0 > > The comparison is perfectly legal for UFS1 so perhaps > gcc gives the "benefit of the doubt" to avoid false positives. >=20 >> Perhaps the larger bugs pointed to this warning were lost in translation= : >> - di_blocks overflows for ffs1.=A0 This is now physically possible. >> ... > Surely not anywhere near a complete solution but perhaps it wouldn't > be incompatible=A0to change i_blocks and friends to be unsigned in UFS1. > That is=A0something that remains to be completed in ext2fs, but according > to fsx there=A0are bigger=A0problems there at this time. That only gives 1 more bit, but 7 more are required (for the expansion factor MAXBSIZE / DEV_BSIZE =3D 2**7). More if someone increases MAXBSIZE. Bruce --0-874308365-1359954289=:932--