From owner-svn-src-head@freebsd.org Wed Jun 20 14:17:16 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 52837101B887 for ; Wed, 20 Jun 2018 14:17:16 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x244.google.com (mail-io0-x244.google.com [IPv6:2607:f8b0:4001:c06::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BBE347C372 for ; Wed, 20 Jun 2018 14:17:15 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x244.google.com with SMTP id g22-v6so3592905iob.7 for ; Wed, 20 Jun 2018 07:17:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=76ASKp0+EP/iQjW5fH6cESMwvHXAR6sRr0uH6N+lTPg=; b=K0RPqOSYalxo9NS+4tJ8tFNW5Vwo+f/tmS84RwmbM9cpktVNUp2w3hZ6GKeVZuXqGg dsNjtmwCtfQZ+7dEcC/mJeypQ7v4AwaiNSw2NKQep/lWCSRTB1DCwCa8mDsof28pPEEv AteDR1ZmoeHUAQrhOq5KzJjw7+z/UuPHUHn90P46FhbDGq8mKamCB5Pp2u5IfDp8vIuF VUrUEZtSHrUFGT30blz+c6+2RS9pxU/cs3bAxc66ZkrTLPZs0yCKwQ0JrUPyx+lGfRCi vfnVzlQA/X5DsDZPJ7arMWQmCTBb72MB3mEmm5NeaILCzChOt+YdQ6KijWsy5JN1Uq+R 5WJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=76ASKp0+EP/iQjW5fH6cESMwvHXAR6sRr0uH6N+lTPg=; b=X/LuLkYhaZMoJ5ANCmbNK3COTgyuIiuATnCrogy2ulDMQn3ugiDwE5iIQctgvtrBqG 7T2T4roQEnFERuQi/PxsTUK3GefNaRO1FBfCS4V9z1xnQbBqqa20ScMs7o3NiYNImQ4S E+gGeuXRcEgtRgLEjwT6b8gVPlLQhZzatvrMC2esDe8u8DIfXLXsnh9EVF4rA2vdr5YW CBfZeEuCC28HTENh0RvUlAfcKQOPj1X1H2CCDhlbH7AEyH2o94fkX/FbkxMiQf8Z7U9t n0xiC0dxlJHUl4ZaVK8gfrNZLQoAQSIgyraovov0h4CWirBZk7bViK4h7zfkcAqP4Ldh kxrA== X-Gm-Message-State: APt69E2XJSGgI+cZKd1PBcTpdjIl+6L0mC9tUP80Xc0HT6joClooTLbv P/0E8sdRhkT3EBy+61ZVYrrgOhf0gpymb3DZW2MFNA== X-Google-Smtp-Source: ADUXVKJvJOGLyzDCWkrmYZatxzDag3OuKnwrWyxMBLgIYyQi1j+SlNWWTwSqIjjqcOZ2H6vt4frvjf0WuGWk/rQmOCM= X-Received: by 2002:a6b:d40c:: with SMTP id l12-v6mr17628348iog.37.1529504234660; Wed, 20 Jun 2018 07:17:14 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 2002:a4f:5945:0:0:0:0:0 with HTTP; Wed, 20 Jun 2018 07:17:14 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: <93b03eb5-326b-5df1-5d41-ae3da163e894@freebsd.org> References: <201806170318.w5H3IvJP090557@repo.freebsd.org> <5B2646B3.4020200@grosbein.net> <93b03eb5-326b-5df1-5d41-ae3da163e894@freebsd.org> From: Warner Losh Date: Wed, 20 Jun 2018 08:17:14 -0600 X-Google-Sender-Auth: xU-hVnGKeNX5FI0UG_iT6JmUSn4 Message-ID: Subject: Re: svn commit: r335276 - in head/stand/i386: gptboot zfsboot To: Allan Jude Cc: Eugene Grosbein , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.26 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jun 2018 14:17:16 -0000 On Tue, Jun 19, 2018 at 6:34 PM, Allan Jude wrote: > On 2018-06-17 07:32, Eugene Grosbein wrote: > > 17.06.2018 10:18, Allan Jude wrote: > > > >> Author: allanjude > >> Date: Sun Jun 17 03:18:56 2018 > >> New Revision: 335276 > >> URL: https://svnweb.freebsd.org/changeset/base/335276 > >> > >> Log: > >> gptboot, zfsboot, gptzfsboot: Enable the video and serial consoles > early > >> > >> Normally the serial console is not enabled until /boot.config is read > and > >> we know how the serial console should be configured. Initialize the > >> consoles early in 'dual' mode (serial & keyboard) with a default > serial > >> rate of 115200. Then serial is re-initialized once the disk is > decrypted > >> and the /boot.config file can be read. > >> > >> This allows the GELIBoot passphrase to be provided via the serial > console. > >> > >> PR: 221526 > >> Requested by: many > >> Reviewed by: imp > >> Sponsored by: Klara Systems > >> Differential Revision: https://reviews.freebsd.org/D15862 > > > > I had several cases when booting FreeBSD/amd64 with motherboard having > no serial ports > > hang hard early at boot unless I rebuilt boot media configuring it to > NOT try accessing > > missing serial ports. I even could reproduce that with VirtualBox > machine configured > > with no serial ports (not same as existing bug inactive serial port). > > > > Should there be some way to disable this serial ports configuration at > compile time? > > > > > > > > I think what we'll do it compile it both ways, and use the non-serial > one by default, because it is safer. Then you can just use > 'gptboot-serial' if you want serial support. > > This will likely make Warner a bit sad, since we are just finally > getting around to reducing the number of different bootcode files. > I think we should *NOT* do that. There is a niche market for this stuff, and we should support building serial-enabled bootblocks on an opt-in basis. The support is really already there, this just enables it early. I agree with kib@ that the target market here is too small to justify a proliferation of new boot blocks. Warner