From owner-svn-ports-all@FreeBSD.ORG  Wed Jul 25 02:25:01 2012
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
	id 1E204106566B; Wed, 25 Jul 2012 02:25:01 +0000 (UTC)
Date: Wed, 25 Jul 2012 02:25:01 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Carlo Strub <cs@FreeBSD.org>
Message-ID: <20120725022501.GA98315@FreeBSD.org>
References: <201207242127.q6OLRE9x075919@svn.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <201207242127.q6OLRE9x075919@svn.freebsd.org>
User-Agent: Mutt/1.4.2.1i
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
	ports-committers@freebsd.org
Subject: Re: svn commit: r301497 - in head: databases/rubygem-dm-migrations
	deskutils/libgcal deskutils/p5-ZConf-BGSet
	deskutils/p5-ZConf-Runner deskutils/xrolo devel/alabastra
	devel/librcd devel/py-pytemplate ...
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
	<mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
	<mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Jul 2012 02:25:01 -0000

On Tue, Jul 24, 2012 at 09:27:14PM +0000, Carlo Strub wrote:
> Author: cs
> Date: Tue Jul 24 21:27:13 2012
> New Revision: 301497
> URL: http://svn.freebsd.org/changeset/ports/301497
> 
> Log:
>   Fix typos in COMMENT

Thanks for doing this, much appreciated!  I've noticed some potential bugs
however, see below...

> +++ head/deskutils/p5-ZConf-Runner/Makefile
> @@ -13,7 +13,7 @@ MASTER_SITE_SUBDIR=	CPAN:VVELOX
>  PKGNAMEPREFIX=	p5-
>  
>  MAINTAINER=	vvelox@vvelox.net
> -COMMENT=	Run a file using a choosen methode, desktop entry or mimetype
> +COMMENT=	Run a file using a chosen method, desktop entry or mimetype

This could benefit from comma before "or" I think.

> +++ head/devel/alabastra/Makefile
> @@ -13,7 +13,7 @@ DISTNAME=	Alabastra-${PORTVERSION}
>  EXTRACT_SUFX=	.tgz
>  
>  MAINTAINER=	ports@FreeBSD.org
> -COMMENT=	C++ Editor writen with QT4
> +COMMENT=	C++ Editor written with QT4

Why capitalize "editor"?

> +++ head/devel/py-pytemplate/Makefile
> @@ -12,7 +12,7 @@ MASTER_SITES=	http://www.bulot.org/downl
>  PKGNAMEPREFIX=	${PYTHON_PKGNAMEPREFIX}
>  
>  MAINTAINER=	benoit@litchis.org
> -COMMENT=	Pytemplate gives python developpers a starting framework
> +COMMENT=	Pytemplate gives python developers a starting framework

Using port's name in COMMENT should generally be avoided.

> +++ head/net-im/emesene/Makefile
> @@ -14,7 +14,7 @@ MASTER_SITES=	${MASTER_SITE_LOCAL:S,$,ac
>  		${MASTER_SITE_GOOGLE_CODE}
>  
>  MAINTAINER=	acm@FreeBSD.org
> -COMMENT=	A MSN Messenger client writen in python
> +COMMENT=	A MSN Messenger client written in python

Shouldn't it be "An MSN ... in Python" ?

./danfe