From owner-svn-src-stable@FreeBSD.ORG Wed Apr 10 17:49:26 2013
Return-Path: <owner-svn-src-stable@FreeBSD.ORG>
Delivered-To: svn-src-stable@freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
by hub.freebsd.org (Postfix) with ESMTP id 763D7CF0;
Wed, 10 Apr 2013 17:49:26 +0000 (UTC) (envelope-from mav@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org
[IPv6:2001:1900:2254:2068::e6a:0])
by mx1.freebsd.org (Postfix) with ESMTP id 67C84DED;
Wed, 10 Apr 2013 17:49:26 +0000 (UTC)
Received: from svn.freebsd.org ([127.0.1.70])
by svn.freebsd.org (8.14.6/8.14.6) with ESMTP id r3AHnQdb015133;
Wed, 10 Apr 2013 17:49:26 GMT (envelope-from mav@svn.freebsd.org)
Received: (from mav@localhost)
by svn.freebsd.org (8.14.6/8.14.5/Submit) id r3AHnQjs015131;
Wed, 10 Apr 2013 17:49:26 GMT (envelope-from mav@svn.freebsd.org)
Message-Id: <201304101749.r3AHnQjs015131@svn.freebsd.org>
From: Alexander Motin <mav@FreeBSD.org>
Date: Wed, 10 Apr 2013 17:49:26 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
svn-src-stable@freebsd.org, svn-src-stable-9@freebsd.org
Subject: svn commit: r249337 - stable/9/sys/cam
X-SVN-Group: stable-9
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-stable@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for all the -stable branches of the src tree
<svn-src-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-stable>,
<mailto:svn-src-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-stable>
List-Post: <mailto:svn-src-stable@freebsd.org>
List-Help: <mailto:svn-src-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-stable>,
<mailto:svn-src-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Apr 2013 17:49:26 -0000
Author: mav
Date: Wed Apr 10 17:49:25 2013
New Revision: 249337
URL: http://svnweb.freebsd.org/changeset/base/249337
Log:
MFC r248800:
On SIM destruction free associated CCBs, preallocated inside xpt_get_ccb().
Before this change they were just leaked. Fortunately USB sticks now use
only one CCB, and so leak was only 2KB per detach, while other bigger SIMs
with much more allocated CCBs are rarely detached.
Modified:
stable/9/sys/cam/cam_sim.c
Directory Properties:
stable/9/sys/ (props changed)
Modified: stable/9/sys/cam/cam_sim.c
==============================================================================
--- stable/9/sys/cam/cam_sim.c Wed Apr 10 17:43:20 2013 (r249336)
+++ stable/9/sys/cam/cam_sim.c Wed Apr 10 17:49:25 2013 (r249337)
@@ -40,6 +40,7 @@ __FBSDID("$FreeBSD$");
#include <cam/cam_ccb.h>
#include <cam/cam_sim.h>
#include <cam/cam_queue.h>
+#include <cam/cam_xpt.h>
#define CAM_PATH_ANY (u_int32_t)-1
@@ -105,6 +106,7 @@ cam_sim_alloc(sim_action_func sim_action
void
cam_sim_free(struct cam_sim *sim, int free_devq)
{
+ union ccb *ccb;
int error;
sim->refcount--;
@@ -115,6 +117,10 @@ cam_sim_free(struct cam_sim *sim, int fr
KASSERT(sim->refcount == 0, ("sim->refcount == 0"));
+ while ((ccb = (union ccb *)SLIST_FIRST(&sim->ccb_freeq)) != NULL) {
+ SLIST_REMOVE_HEAD(&sim->ccb_freeq, xpt_links.sle);
+ xpt_free_ccb(ccb);
+ }
if (free_devq)
cam_simq_free(sim->devq);
free(sim, M_CAMSIM);