Date: Fri, 14 Jul 2006 15:31:50 +0000 (UTC) From: Emanuel Haupt <ehaupt@FreeBSD.org> To: ports-committers@FreeBSD.org, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: ports/graphics/xv Makefile ports/graphics/xv/files patch-xvxwd.c Message-ID: <200607141531.k6EFVou0000310@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
ehaupt 2006-07-14 15:31:50 UTC
FreeBSD ports repository
Modified files:
graphics/xv Makefile
Added files:
graphics/xv/files patch-xvxwd.c
Log:
With 24/32-bit xwd files, xv swaps the red and blue channels. With 16-bit xwd
files, the image is very dark green (almost black).
Both problems are caused by hard-coding the channel order and offsets, rather
than using the colour masks in the xwd header.
xv reads the input into a 24-bit internal image, which is then displayed. The
lack of brightness in the 16-bit display is because the colour values are copied
into the low-order bits of the internal pixmap rather than the high order bits.
The green hue is because the green channel has 6 bits, whereas red and blue only
have 5 bits, making the green twice as (relatively) bright.
The new patch solves that problem.
PR: 96971
Submitted by: Peter Jeremy <peterjeremy@optushome.com.au>
Approved by: Miguel Mendez <mmendez@gmail.com> (maintainer)
Revision Changes Path
1.65 +1 -1 ports/graphics/xv/Makefile
1.1 +171 -0 ports/graphics/xv/files/patch-xvxwd.c (new)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200607141531.k6EFVou0000310>