From owner-freebsd-current@FreeBSD.ORG Mon Apr 7 17:47:05 2008 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4F11A1065670 for ; Mon, 7 Apr 2008 17:47:05 +0000 (UTC) (envelope-from keramida@ceid.upatras.gr) Received: from igloo.linux.gr (igloo.linux.gr [62.1.205.36]) by mx1.freebsd.org (Postfix) with ESMTP id 9B9368FC15 for ; Mon, 7 Apr 2008 17:47:04 +0000 (UTC) (envelope-from keramida@ceid.upatras.gr) Received: from kobe.laptop (vader.bytemobile-rio.ondsl.gr [83.235.57.37]) (authenticated bits=128) by igloo.linux.gr (8.14.2/8.14.2/Debian-3) with ESMTP id m37HR3e9031434 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 7 Apr 2008 20:27:16 +0300 Received: from kobe.laptop (kobe.laptop [127.0.0.1]) by kobe.laptop (8.14.2/8.14.2) with ESMTP id m37HQvIw008338; Mon, 7 Apr 2008 20:26:57 +0300 (EEST) (envelope-from keramida@ceid.upatras.gr) Received: (from keramida@localhost) by kobe.laptop (8.14.2/8.14.2/Submit) id m37HQuoW008325; Mon, 7 Apr 2008 20:26:56 +0300 (EEST) (envelope-from keramida@ceid.upatras.gr) From: Giorgos Keramidas To: Jille References: <47F95B6D.80006@quis.cx> <20080407083746.GL5934@hoeg.nl> <47FA0BC1.3010803@quis.cx> Date: Mon, 07 Apr 2008 20:26:56 +0300 In-Reply-To: <47FA0BC1.3010803@quis.cx> (jille@quis.cx's message of "Mon, 07 Apr 2008 13:55:45 +0200") Message-ID: <87myo58tjz.fsf@kobe.laptop> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-MailScanner-ID: m37HR3e9031434 X-Hellug-MailScanner: Found to be clean X-Hellug-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-3.969, required 5, autolearn=not spam, ALL_TRUSTED -1.80, AWL 0.43, BAYES_00 -2.60) X-Hellug-MailScanner-From: keramida@ceid.upatras.gr X-Spam-Status: No Cc: Ed Schouten , freebsd-current@freebsd.org Subject: Re: werase patch for src/contrib/top X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Apr 2008 17:47:05 -0000 On Mon, 07 Apr 2008 13:55:45 +0200, Jille wrote: > Ed Schouten schreef: > | * Jille Timmermans wrote: > |> I've patched top (in src/contrib) to accept ^W in line editing mode (eg > |> when killing a process (hit 'k')) > |> > |> The patch is attached, and I hope mailman won't eat it, or else: > |> http://junk.quis.cx/NbVJSKxn/top-werase-patch.diff > |> there it is :) > |> I took the RELENG_6 version, and editted that one. > | > | Apart from some style(9) issues, it looks great. Unfortunately the > | top(8) source code is not maintained by FreeBSD. Its website seems to be Hi Ed, The original contrib/top source doesn't really follow style(9); it has a style of its own, so some of the changes look `good enough'. Can you describe what you didn't like, so we can fix it before it's committed? > Hello Ed, > After an hour of reading style(9), I've fixed my patch, thanks for > pointing out. Unixtop seems to be on SourceForge now, so I will > submit it to their patch-tracker. It would be nice if we also committed something similar to our top, since many top sources in src/contrib/top are already *off* the vendor branch anyway :-)