From owner-freebsd-bugs@FreeBSD.ORG  Thu Oct 31 09:30:02 2013
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 22462F80
 for <freebsd-bugs@smarthost.ysv.freebsd.org>;
 Thu, 31 Oct 2013 09:30:02 +0000 (UTC)
 (envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id EAFCF2D08
 for <freebsd-bugs@smarthost.ysv.freebsd.org>;
 Thu, 31 Oct 2013 09:30:01 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r9V9U1aG097606
 for <freebsd-bugs@freefall.freebsd.org>; Thu, 31 Oct 2013 09:30:01 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r9V9U11X097605;
 Thu, 31 Oct 2013 09:30:01 GMT (envelope-from gnats)
Date: Thu, 31 Oct 2013 09:30:01 GMT
Message-Id: <201310310930.r9V9U11X097605@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
Cc: 
From: dfilter@FreeBSD.ORG (dfilter service)
Subject: Re: bin/183484: commit references a PR
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 31 Oct 2013 09:30:02 -0000

The following reply was made to PR bin/183484; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/183484: commit references a PR
Date: Thu, 31 Oct 2013 09:29:45 +0000 (UTC)

 Author: kib
 Date: Thu Oct 31 09:29:37 2013
 New Revision: 257430
 URL: http://svnweb.freebsd.org/changeset/base/257430
 
 Log:
   Remove the dependency on procfs.  Use sysctl KERN_PROC_PATHNAME and
   KERN_PROC_PID to obtain the parent process pathname and command, used
   to determine the calling shell.
   
   Submitted by:	Stefan Neudorf
   PR:	bin/183484
   MFC after:	1 week
 
 Modified:
   head/usr.bin/limits/limits.c
 
 Modified: head/usr.bin/limits/limits.c
 ==============================================================================
 --- head/usr.bin/limits/limits.c	Thu Oct 31 09:20:30 2013	(r257429)
 +++ head/usr.bin/limits/limits.c	Thu Oct 31 09:29:37 2013	(r257430)
 @@ -30,6 +30,7 @@ __FBSDID("$FreeBSD$");
  #include <sys/types.h>
  #include <sys/stat.h>
  #include <sys/sysctl.h>
 +#include <sys/user.h>
  #include <sys/param.h>
  #include <stdlib.h>
  #include <unistd.h>
 @@ -705,27 +706,32 @@ getshelltype(void)
      pid_t ppid = getppid();
  
      if (ppid != 1) {
 -	FILE * fp;
 +	struct kinfo_proc kp;
  	struct stat st;
 -	char procdir[MAXPATHLEN], buf[128];
 -	int l = sprintf(procdir, "/proc/%ld/", (long)ppid);
 +	char path[MAXPATHLEN];
  	char * shell = getenv("SHELL");
 +	int mib[4];
 +	size_t len;
 +
 +	mib[0] = CTL_KERN;
 +	mib[1] = KERN_PROC;
 +	mib[3] = ppid;
  
  	if (shell != NULL && stat(shell, &st) != -1) {
  	    struct stat st1;
  
 -	    strcpy(procdir+l, "file");
 -	    /* $SHELL is actual shell? */
 -	    if (stat(procdir, &st1) != -1 && memcmp(&st, &st1, sizeof st) == 0)
 -		return getshellbyname(shell);
 -	}
 -	strcpy(procdir+l, "status");
 -	if (stat(procdir, &st) == 0 && (fp = fopen(procdir, "r")) != NULL) {
 -	    char * p = fgets(buf, sizeof buf, fp)==NULL ? NULL : strtok(buf, " \t");
 -	    fclose(fp);
 -	    if (p != NULL)
 -		return getshellbyname(p);
 +	    mib[2] = KERN_PROC_PATHNAME;
 +	    len = sizeof(path);
 +	    if (sysctl(mib, 4, path, &len, NULL, 0) != -1) {
 +		/* $SHELL is actual shell? */
 +		if (stat(path, &st1) != -1 && memcmp(&st, &st1, sizeof st) == 0)
 +		    return getshellbyname(shell);
 +	    }
  	}
 +	mib[2] = KERN_PROC_PID;
 +	len = sizeof(kp);
 +	if (sysctl(mib, 4, &kp, &len, NULL, 0) != -1)
 +	    return getshellbyname(kp.ki_comm);
      }
      return SH_SH;
  }
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"