From owner-svn-src-head@FreeBSD.ORG  Fri Oct 19 15:32:34 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 63677D5;
 Fri, 19 Oct 2012 15:32:34 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net
 [IPv6:2001:470:1f10:75::2])
 by mx1.freebsd.org (Postfix) with ESMTP id 2FA1B8FC1A;
 Fri, 19 Oct 2012 15:32:34 +0000 (UTC)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
 by bigwig.baldwin.cx (Postfix) with ESMTPSA id 75C60B993;
 Fri, 19 Oct 2012 11:32:33 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: Ed Schouten <ed@freebsd.org>
Subject: Re: svn commit: r241737 - in head: bin/date bin/ed libexec/rtld-aout
 sbin/camcontrol sbin/geom/core usr.bin/at usr.bin/calendar usr.bin/chat
 usr.bin/ctlstat usr.bin/elfdump usr.bin/fetch usr.bin/finger...
Date: Fri, 19 Oct 2012 11:18:42 -0400
User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p20; KDE/4.5.5; amd64; ; )
References: <201210191449.q9JEnhfn015510@svn.freebsd.org>
In-Reply-To: <201210191449.q9JEnhfn015510@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201210191118.42722.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
 (bigwig.baldwin.cx); Fri, 19 Oct 2012 11:32:33 -0400 (EDT)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 19 Oct 2012 15:32:34 -0000

On Friday, October 19, 2012 10:49:43 am Ed Schouten wrote:
> Author: ed
> Date: Fri Oct 19 14:49:42 2012
> New Revision: 241737
> URL: http://svn.freebsd.org/changeset/base/241737
> 
> Log:
>   More -Wmissing-variable-declarations fixes.
>   
>   In addition to adding `static' where possible:
>   
>   - usr.sbin/mfiutil: Put global variables in mfiutil.h.

The fw_* changes here probably wasn't the right way to fix this.  The 
variables should be static.  The problem is that 'scan_firmware()' is
duplicated and should probably be reduced to a single copy.

-- 
John Baldwin