From nobody Thu Aug 6 08:29:55 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hG0nv5ssGz6mcRL for ; Thu, 06 Aug 2026 08:29:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hG0nv52X6z3Q1W for ; Thu, 06 Aug 2026 08:29:55 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786004995; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xLM6DfwTQsW/OSiZMVoEZWtEiyS9hVzfgPavC2b6OYo=; b=Ybf7cC085eD1TTkXv0k4Ov1/TtQFSsCWgqE+HbtDL/ODGoRzQStLcC7MLJXZoJQdezu6Fw rncRqSY/GF0yZOT3eFhbNYT/kAl4rSPmyJAy6n1x8WomCq1ASQxkRuhD9+3JUSAh2Oyeva iVwknSdI8eXoXJxBqzP8TyUGQMyTOAbT5UR3SdwaNwuQVYEjT8cXfS11rpIz/yTUmgM4Pn vkSPS7meRSmzoOh+jwv8myHqqYm/IrGu+djQeyq/xdWK7K73xpS8oHhfnIlHqV8Utw/s6r MU85IrUOi73wLChzdzV85TsNJoC6c5YF/Ck3xHpTF6sfFSfu10JX3koVMqFT2A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1786004995; a=rsa-sha256; cv=none; b=iSS+Q30314A/mfVn0JwD3lhIeZHOX9lNjZSzZZcuTqLwD/AJmR7Myv4avNjIhHrNBLfvRI 4JNpK12rFkvefjvasv1c3o3m9XSRE49uLHfBrQEpSklfJndsoggqyExzBBFKQuayKww2Gu K9U9Gd418qh8D3dX60LN1Y/YSz6AE90eRHh75H9vTER0RM9GKT7mBU8zhFVoEbxK1odAyW QY8UWhKNSdeMbFGLwMbl7LqmqsabXmoNO5D1kBz4wCR+mihYcr1rMnIB2XjHFpcFu4wZvw qh/bypoA4oEh65oO6InhsKvwO3P94dwIW5WESSGs4G+KCt27AV5HZLkOf+R5FA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786004995; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xLM6DfwTQsW/OSiZMVoEZWtEiyS9hVzfgPavC2b6OYo=; b=D09puejZltXHE0e7YLbxeNhlA6d1A/2rvtTGOH7pXk9aJYHuhdEc0sfEPkPU8KQ6OyJ5Nk FaC9GdMBR3qjTDbjTi8BrX0sZZvFKJxtWcRGMjE3pCacrWzOlYyJ3eWKH8nWooR2fuGv8+ 9TpaTLHUDSMMUbghIggihrPrLt0xrmGrnNla5gFO5kasYkBpTLTIb3fjguVfGFX2d2tR7W GRHh9ytX+e/ojDN2xULuiw9JGglzZ2Zt1pAZRVbSncthhh/Z2e40sK0ss6ynMmxNkL4Mlg 7+Vc88ImfL34bjikV+GlCUKdbocEz11adrMCDmdkoXS6eLzK79uQ8fm2Pc2xUA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hG0nv3YCsz1Bns for ; Thu, 06 Aug 2026 08:29:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3c8a5 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 06 Aug 2026 08:29:55 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Michael Tuexen Subject: git: 0ef3c9162330 - stable/14 - tests: fix checksum computation List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 0ef3c91623307f04102e45bcff932388bb0f4ed1 Auto-Submitted: auto-generated Date: Thu, 06 Aug 2026 08:29:55 +0000 Message-Id: <6a744603.3c8a5.6d95edc1@gitrepo.freebsd.org> The branch stable/14 has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=0ef3c91623307f04102e45bcff932388bb0f4ed1 commit 0ef3c91623307f04102e45bcff932388bb0f4ed1 Author: Michael Tuexen AuthorDate: 2026-07-01 16:07:04 +0000 Commit: Michael Tuexen CommitDate: 2026-08-06 05:52:32 +0000 tests: fix checksum computation This fixes an endianness bug in sys/netinet/ip_reass_test. Just use the code from RFC 1071. Reported by: glebius Reviewed by: glebius, Timo Völker Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D57988 (cherry picked from commit fbc039e512c3bb1635ad20cc8f70ad608ea818b7) --- tests/sys/netinet/ip_reass_test.c | 26 +++++++++++++++++--------- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/tests/sys/netinet/ip_reass_test.c b/tests/sys/netinet/ip_reass_test.c index f649dd9ad4db..dd18b56f069f 100644 --- a/tests/sys/netinet/ip_reass_test.c +++ b/tests/sys/netinet/ip_reass_test.c @@ -56,20 +56,28 @@ struct lopacket { char payload[]; }; -static void -update_cksum(struct ip *ip) +static uint16_t +in_cksum(void *data, size_t len) { + uint16_t *cksump; size_t i; uint32_t cksum; - uint16_t *cksump; + ATF_REQUIRE(len % 2 == 0); + cksump = (uint16_t *)data; + cksum = 0; + for (i = 0; i < len / sizeof(uint16_t); i++) + cksum += *cksump++; + while ((cksum >> 16) != 0) + cksum = (cksum & 0xffff) + (cksum >> 16); + return ((uint16_t)~cksum); +} + +static void +update_cksum(struct ip *ip) +{ ip->ip_sum = 0; - cksump = (uint16_t *)ip; - for (cksum = 0, i = 0; i < sizeof(*ip) / sizeof(*cksump); cksump++, i++) - cksum += ntohs(*cksump); - cksum = (cksum >> 16) + (cksum & 0xffff); - cksum = ~(cksum + (cksum >> 16)); - ip->ip_sum = htons((uint16_t)cksum); + ip->ip_sum = in_cksum(ip, sizeof(struct ip)); } static struct lopacket *