From owner-p4-projects@FreeBSD.ORG  Fri Jul 25 13:33:01 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 2DB841065674; Fri, 25 Jul 2008 13:33:01 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E54361065673
	for <perforce@FreeBSD.org>; Fri, 25 Jul 2008 13:33:00 +0000 (UTC)
	(envelope-from strauss@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id CE2078FC0C
	for <perforce@FreeBSD.org>; Fri, 25 Jul 2008 13:33:00 +0000 (UTC)
	(envelope-from strauss@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.2/8.14.2) with ESMTP id m6PDX0ON079278
	for <perforce@FreeBSD.org>; Fri, 25 Jul 2008 13:33:00 GMT
	(envelope-from strauss@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.2/8.14.1/Submit) id m6PDX06I079276
	for perforce@freebsd.org; Fri, 25 Jul 2008 13:33:00 GMT
	(envelope-from strauss@FreeBSD.org)
Date: Fri, 25 Jul 2008 13:33:00 GMT
Message-Id: <200807251333.m6PDX06I079276@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	strauss@FreeBSD.org using -f
From: Anselm Strauss <strauss@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 145885 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 25 Jul 2008 13:33:01 -0000

http://perforce.freebsd.org/chv.cgi?CH=145885

Change 145885 by strauss@strauss_marvelman on 2008/07/25 13:32:02

	Cloning archive entry instead of referencing it for data descriptors (Tim)

Affected files ...

.. //depot/projects/soc2008/strauss_libarchive/libarchive/archive_write_set_format_zip.c#18 edit
.. //depot/projects/soc2008/strauss_libarchive/libarchive/test/test_write_format_zip_no_compression.c#3 edit

Differences ...

==== //depot/projects/soc2008/strauss_libarchive/libarchive/archive_write_set_format_zip.c#18 (text+ko) ====

@@ -173,7 +173,7 @@
 		archive_set_error(&a->archive, ENOMEM, "Can't allocate zip header data");
 		return (ARCHIVE_FATAL);
 	}
-	l->entry = entry; /* TODO: Maybe bad idea, do copy or store only needed fields. */
+	l->entry = archive_entry_clone(entry);
 	l->next = zip->central_directory;
 	zip->central_directory = l;
 	

==== //depot/projects/soc2008/strauss_libarchive/libarchive/test/test_write_format_zip_no_compression.c#3 (text+ko) ====