From owner-freebsd-ports@FreeBSD.ORG  Tue Jun 10 18:29:47 2008
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 678BD1065675
	for <ports@freebsd.org>; Tue, 10 Jun 2008 18:29:47 +0000 (UTC)
	(envelope-from kris@FreeBSD.org)
Received: from weak.local (freefall.freebsd.org [IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id A21298FC19;
	Tue, 10 Jun 2008 18:29:45 +0000 (UTC)
	(envelope-from kris@FreeBSD.org)
Message-ID: <484EC819.30706@FreeBSD.org>
Date: Tue, 10 Jun 2008 20:29:45 +0200
From: Kris Kennaway <kris@FreeBSD.org>
User-Agent: Thunderbird 2.0.0.14 (Macintosh/20080421)
MIME-Version: 1.0
To: Jeremy Messenger <mezz7@cox.net>
References: <484EAFAC.3020208@FreeBSD.org> <op.ucjovyxo9aq2h7@mezz.mezzweb.com>
In-Reply-To: <op.ucjovyxo9aq2h7@mezz.mezzweb.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: ports@freebsd.org
Subject: Re: INDEX build optimizations - please review
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Jun 2008 18:29:47 -0000

Jeremy Messenger wrote:
> On Tue, 10 Jun 2008 11:45:32 -0500, Kris Kennaway <kris@FreeBSD.org> wrote:
> 
>> Another important optimization is to use /rescue/sh instead of /bin/sh 
>> for index builds.  The former is statically linked and this is much 
>> faster to execute.
> 
> I don't have INDEX in all of my systems, so I am only take a peek. What 
> about users that have WITHOUT_RESCUE defined or/and something different? 
> IMO, I think your patch should have a check on if /rescue/sh exists when 
> our src provides optional of WITHOUT_RESCUE and is harmless to kill the 
> /rescue.
> 
> ------------------------------
> .if exists(/rescue/sh)
> __MAKE_SHELL=/rescue/sh
> .else
> __MAKE_SHELL=/bin/sh
> .endif
> ------------------------------

Yeah, I will add this in the next version.

> Thanks for hint on 'NOTE TO PORT DEVELOPERS' part as I didn't know about 
> VARIABLE!= vs $(${VARIABLE_CMDS}). /me copies it in my note.

What would be good is if someone can add it to the porter's handbook.

> As for the audio/festvox-hvs issue, probably because of no executables 
> or files in RUN_DEPENDS:
> 
> ------------------------------
> RUN_DEPENDS=    ${PORTSDIR}/audio/festival+OGI \
>         ${PORTSDIR}/audio/festlex-poslex \
>         ${PORTSDIR}/audio/festlex-ogi \
>         ${PORTSDIR}/audio/festogi-spanish
> ------------------------------

Ah yes, good catch.  This looks like a port bug, so I don't think I need 
to modify my patches.

Kris