From owner-cvs-all@FreeBSD.ORG Sat Oct 9 16:48:52 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 110A916A4CE; Sat, 9 Oct 2004 16:48:52 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E3F5743D49; Sat, 9 Oct 2004 16:48:51 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i99GmpoE011097; Sat, 9 Oct 2004 16:48:51 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i99GmpDq011096; Sat, 9 Oct 2004 16:48:51 GMT (envelope-from rwatson) Message-Id: <200410091648.i99GmpDq011096@repoman.freebsd.org> From: Robert Watson Date: Sat, 9 Oct 2004 16:48:51 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netinet tcp_output.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Oct 2004 16:48:52 -0000 rwatson 2004-10-09 16:48:51 UTC FreeBSD src repository Modified files: sys/netinet tcp_output.c Log: Acquire the send socket buffer lock around tcp_output() activities reaching into the socket buffer. This prevents a number of potential races, including dereferencing of sb_mb while unlocked leading to a NULL pointer deref (how I found it). Potentially this might also explain other "odd" TCP behavior on SMP boxes (although haven't seen it reported). RELENG_5 candidate. Revision Changes Path 1.103 +14 -2 src/sys/netinet/tcp_output.c