From owner-freebsd-net Thu Sep 27 4:27:30 2001 Delivered-To: freebsd-net@freebsd.org Received: from mmu.edu.my (ext-dns.mmu.edu.my [203.106.62.11]) by hub.freebsd.org (Postfix) with ESMTP id DF6B937B420 for ; Thu, 27 Sep 2001 04:27:22 -0700 (PDT) Received: from venus.cyber.mmu.edu.my (venus.cyber.mmu.edu.my [203.106.62.12]) by mmu.edu.my (8.9.1b+Sun/8.9.1) with ESMTP id TAA11236; Thu, 27 Sep 2001 19:23:12 +0800 (MYT) Received: from there ([10.100.99.41]) by venus.cyber.mmu.edu.my (8.8.8+Sun/8.8.8) with SMTP id TAA22756; Thu, 27 Sep 2001 19:22:58 +0800 (SGT) Message-Id: <200109271122.TAA22756@venus.cyber.mmu.edu.my> Content-Type: text/plain; charset="iso-8859-1" From: nuzrin yaapar Reply-To: nuzrin@goose.net.my Organization: multimedia university To: Josef Karthauser , Stephen Hurd Subject: Re: Patch to allow disabling logging of arp movements through sysctl Date: Thu, 27 Sep 2001 19:36:23 +0800 X-Mailer: KMail [version 1.3] Cc: net@FreeBSD.org References: <20010903224210.C28738@tao.org.uk> In-Reply-To: <20010903224210.C28738@tao.org.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org is there any chance this patch will be commited soon to the -STABLE tree? i'm having a similar problems and it's driving me crazy. my log is full with all the arp movement messages. On Tuesday 04 September 2001 5:42 am, Josef Karthauser wrote: > You should really send this to net@FreeBSD.org (Cc'd). Filing a -PR is a > good thing too, as you can always refer to the -PR number in any mail to > the list. > > Joe > > On Mon, Sep 03, 2001 at 03:43:41PM -0600, Stephen Hurd wrote: > > I've had a problem with my DSL connection for some time now, the bridging > > they use appears to forward arp responses AND respond to arp requests. > > This ends up filling my log with: > > > > Sep 3 15:17:57 tw2 /kernel: arp: 216.13.207.2 moved from > > 00:06:29:d5:04:c7 to 00:10:b5:4f:d1:1a on rl0 > > Sep 3 15:17:57 tw2 /kernel: arp: 216.13.207.2 moved from > > 00:10:b5:4f:d1:1a to 00:06:29:d5:04:c7 on rl0 > > > > I've dug around on the list archives, and it looks like I'm not the first > > person to get annoyed at this, but I haven't found a solution. So, I've > > finally gotten so annoyed at my huge logs that I broke down and added the > > following patch to add the sysctl variable > > net.link.ether.inet.log_arp_movements > > > > Is this the "right place" to send the patch or should I file a PR? > > > > --- /usr/src/sys/netinet/if_ether.c.old Mon Sep 3 14:26:38 2001 > > +++ /usr/src/sys/netinet/if_ether.c Mon Sep 3 15:13:08 2001 > > @@ -497,10 +497,15 @@ > > * but formerly didn't normally send requests. > > */ > > static int log_arp_wrong_iface = 1; > > +static int log_arp_movements = 1; > > > > SYSCTL_INT(_net_link_ether_inet, OID_AUTO, log_arp_wrong_iface, > > CTLFLAG_RW, &log_arp_wrong_iface, 0, > > "log arp packets arriving on the wrong interface"); > > +SYSCTL_INT(_net_link_ether_inet, OID_AUTO, log_arp_movements, > > CTLFLAG_RW, + &log_arp_movements, 0, > > + "log arp replies from MACs different the the one in the cache"); > > + > > > > static void > > in_arpinput(m) > > @@ -586,12 +591,13 @@ > > } > > if (sdl->sdl_alen && > > bcmp((caddr_t)ea->arp_sha, LLADDR(sdl), sdl->sdl_alen)) { > > - if (rt->rt_expire) > > - log(LOG_INFO, "arp: %s moved from %6D to %6D on %s%d\n", > > - inet_ntoa(isaddr), (u_char *)LLADDR(sdl), ":", > > - ea->arp_sha, ":", > > - ac->ac_if.if_name, ac->ac_if.if_unit); > > - else { > > + if (rt->rt_expire) { > > + if (log_arp_movements) > > + log(LOG_INFO, "arp: %s moved from %6D to %6D on %s%d\n", > > + inet_ntoa(isaddr), (u_char *)LLADDR(sdl), ":", > > + ea->arp_sha, ":", > > + ac->ac_if.if_name, ac->ac_if.if_unit); > > + } else { > > log(LOG_ERR, > > "arp: %6D attempts to modify permanent entry for %s on %s%d\n", > > ea->arp_sha, ":", inet_ntoa(isaddr), > > > > > > > > To Unsubscribe: send mail to majordomo@FreeBSD.org > > with "unsubscribe freebsd-hackers" in the body of the message To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message