From nobody Sun Jul 19 20:40:47 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4h3FsW3G11z6lb1t for ; Sun, 19 Jul 2026 20:40:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4h3FsW2m9Cz3vGb for ; Sun, 19 Jul 2026 20:40:47 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1784493647; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nXxTAfi0LDfBLDpT05D1WaKcOOvT8pbX4IxnTRCskb4=; b=F/vxEPug/Sy7Mg0kxeszylNvXDXk51H06WZ8yATrsVUEeW8BNzquruHnIbrrs7TdKLmEhe 9XKF8uav8dKRs8afse6hfSf5cF26UG/y6hRCvj6Jav+ASzmJf3TQoKkGAmu9nY53mUDvL1 cabB7EJT7ZqgYB4iuFTnBnTLkIxStDxUiinCqgW3XiTftUrtxHQZngTcbY5YSAlqRzgA4M GStksQvTTtAgj7LutqOmKIW8yHnA54ec5x5sw9pQAecKUMSlsZsQkmETefIYt1AWoikahv 7ygFC68XT/W4rxPwVlpwSwu3aCh9YVau6Ce/0ormXtZR7+6go30RAtjbkLpwsA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1784493647; a=rsa-sha256; cv=none; b=CaXkU4EWSC/llArocI9Iw4/drDBA33wvyJoGl9vSo9Mt4YJVx6NsUiJ7qoNuK6M9joER6l lQPcKxkFvTclm6frGT3TnttqmNIlWIqkvSDJhzSKBIuH5HaDlVZ/suUnboueJpOgG7aFhS hd/0HvmfeKm2JiCDUnqY6YrbdYVVutrzQGjJahdBSLtqbanSsm4AHPFK0nbG5teqzAJprT /fu5NCmcSYHDir2yEihwyJsgLSM5Ly/T829ohanXGL+bdN7sL94pPc3/uKo165HuSGvKw2 cKlxn9jhKObqoSpLEzfZv250AcDeoao8v3LMAGe8eSHXxaiBQeMXI+d/sBL21g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1784493647; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nXxTAfi0LDfBLDpT05D1WaKcOOvT8pbX4IxnTRCskb4=; b=YzRYk+NpBMItbAj3PDo3dCslrtxWh4QLbj8ffkULkdY8IJ5Pcf4xKOtOVYt2cMOkG32oKb SEhmRie3GX9GNyck1+6JgVcc05X5v1oJcX/wpZA+9INmiB7C9eoSX6QwuXYLgDXyDGP+xN EJ2vGA2+ka4O37nZTlZndlx9wdA59xZ6fV5VH3110VQgKZ4Lp14YiDx1y9BM7k/mrrLa0U wVbconTOjLKv4KvXONp5thfPPiYUgPsV8F6loenK6+N7df7GElJMI+Djz82+o+FVCKlfVq e8tfc0Ub/OGV4K5Iht9B+Pp+DSVirB+YRmnLd3Tb3WoIeVbvKn7EMzsUkR48lQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4h3FsW1XMKzX2J for ; Sun, 19 Jul 2026 20:40:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1944d by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 19 Jul 2026 20:40:47 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: e8d4d754e1c7 - main - EVFILT_PROCDESC: support NOTE_FORK List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: e8d4d754e1c73b01c89580a26c22f982415c694a Auto-Submitted: auto-generated Date: Sun, 19 Jul 2026 20:40:47 +0000 Message-Id: <6a5d364f.1944d.1b2df9c2@gitrepo.freebsd.org> The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=e8d4d754e1c73b01c89580a26c22f982415c694a commit e8d4d754e1c73b01c89580a26c22f982415c694a Author: Konstantin Belousov AuthorDate: 2026-07-16 00:49:02 +0000 Commit: Konstantin Belousov CommitDate: 2026-07-19 20:39:29 +0000 EVFILT_PROCDESC: support NOTE_FORK Reviewed by: markj Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D58292 --- sys/kern/kern_fork.c | 9 +++++++++ sys/kern/sys_procdesc.c | 19 +++++++++++++++++++ sys/sys/event.h | 3 ++- sys/sys/procdesc.h | 2 ++ 4 files changed, 32 insertions(+), 1 deletion(-) diff --git a/sys/kern/kern_fork.c b/sys/kern/kern_fork.c index 26e2510698e2..60d89c03f865 100644 --- a/sys/kern/kern_fork.c +++ b/sys/kern/kern_fork.c @@ -825,6 +825,15 @@ do_fork(struct thread *td, struct fork_req *fr, struct proc *p2, struct thread * sx_xunlock(&proctree_lock); } + /* + * Activate procdesc NOTE_FORK after we attached the debugger + * to the child. This guarantees that a debugger which does + * kevent() on the process descriptor to get notifications of + * fork events, can properly observe the child right after the + * notification fired. + */ + procdesc_fork(p1, p2->p_pid); + racct_proc_fork_done(p2); if ((fr->fr_flags & RFSTOPPED) == 0) { diff --git a/sys/kern/sys_procdesc.c b/sys/kern/sys_procdesc.c index 152f24c219c9..fd4b660d6afa 100644 --- a/sys/kern/sys_procdesc.c +++ b/sys/kern/sys_procdesc.c @@ -335,6 +335,22 @@ procdesc_jobstate(struct proc *p) wakeup(&p->p_procdesc); } +void +procdesc_fork(struct proc *p, pid_t child_pid) +{ + struct procdesc *pd; + + PROC_LOCK(p); + pd = p->p_procdesc; + if (pd != NULL) { + PROCDESC_LOCK(pd); + pd->pd_last_child = child_pid; + KNOTE_LOCKED(&pd->pd_selinfo.si_note, NOTE_FORK); + PROCDESC_UNLOCK(pd); + } + PROC_UNLOCK(p); +} + /* * When a process descriptor is reaped, perhaps as a result of close(), release * the process's reference on the process descriptor. @@ -506,6 +522,9 @@ procdesc_kqops_event(struct knote *kn, long hint) return (1); } + if ((kn->kn_fflags & NOTE_FORK) != 0) + kn->kn_data = pd->pd_last_child; + return (kn->kn_fflags != 0); } diff --git a/sys/sys/event.h b/sys/sys/event.h index ed215453a325..9b8a3ba2bcf1 100644 --- a/sys/sys/event.h +++ b/sys/sys/event.h @@ -204,7 +204,8 @@ struct freebsd11_kevent32 { */ #define NOTE_EXIT 0x80000000 /* proc/procdesc: process exited */ -#define NOTE_FORK 0x40000000 /* proc: process forked */ +#define NOTE_FORK 0x40000000 /* proc/procdesc: process + forked */ #define NOTE_EXEC 0x20000000 /* proc: process exec'd */ #define NOTE_PDSIGCHLD 0x10000000 /* procdesc: pdwait() info available */ diff --git a/sys/sys/procdesc.h b/sys/sys/procdesc.h index 5ca93d3f4646..ac23dbdcb53b 100644 --- a/sys/sys/procdesc.h +++ b/sys/sys/procdesc.h @@ -64,6 +64,7 @@ struct procdesc { */ struct proc *pd_proc; /* (t) Process. */ pid_t pd_pid; /* (c) Cached pid. */ + pid_t pd_last_child; /* (p) Pid of the last child. */ u_int pd_refcount; /* (r) Reference count. */ u_int pd_fpcount; /* (p|t) files referencing me */ @@ -102,6 +103,7 @@ struct procdesc { * In-kernel interfaces to process descriptors. */ bool procdesc_exit(struct proc *); +void procdesc_fork(struct proc *p, pid_t child_pid); void procdesc_jobstate(struct proc *p); int kern_pdgetpid(struct thread *, int fd, const cap_rights_t *, pid_t *pidp);