From owner-svn-src-head@freebsd.org Wed Dec 12 02:07:39 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 57DB7132729D; Wed, 12 Dec 2018 02:07:39 +0000 (UTC) (envelope-from sjg@juniper.net) Received: from mx0b-00273201.pphosted.com (mx0b-00273201.pphosted.com [67.231.152.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.pphosted.com", Issuer "Thawte RSA CA 2018" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9C9526C5F9; Wed, 12 Dec 2018 02:07:38 +0000 (UTC) (envelope-from sjg@juniper.net) Received: from pps.filterd (m0108162.ppops.net [127.0.0.1]) by mx0b-00273201.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id wBC25DS3010418; Tue, 11 Dec 2018 18:07:32 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; h=to : cc : subject : in-reply-to : references : from : mime-version : content-type : content-id : date : message-id; s=PPS1017; bh=D0y/PRgvWGmybYlFhv0q2JflkvDycKClc52M+TKGjpQ=; b=IXYVGaeNrQFx/IGMjg60/Ao4+BhN+5+tW/2cp3vNIU2jRtm8Gt4T/aoSi37EnKotZGPH gCZ7gE6PibkSpKezuTXD+cEXKWWjoJjz5Avg+dSituuQ4EOQjxYWbgVwpJd4u0SM5t9H ec41xYlaZzi80DmEbG208Pj7bZBoV91JyF8OgRLWrGbB+NsL13drCaOFeZ0esOEai1dC lpvMkLHdgn0P5r1nKpOh9aqNM+1RYzqXSk0PgsTe7pcu4KSa5/l8nhZpAL4iKq1rWXHX ep0BMeOzdXQlUdqfJNltm73LNN+ZveXDXAQbQ7iNhjKfY43yLBh0VHTp0px6y0U2J6Um QA== Received: from nam03-by2-obe.outbound.protection.outlook.com (mail-by2nam03lp2056.outbound.protection.outlook.com [104.47.42.56]) by mx0b-00273201.pphosted.com with ESMTP id 2pap9k0862-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 11 Dec 2018 18:07:32 -0800 Received: from CO2PR05CA0086.namprd05.prod.outlook.com (2603:10b6:104:1::12) by DM5PR05MB3273.namprd05.prod.outlook.com (2603:10b6:3:c8::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1425.10; Wed, 12 Dec 2018 02:07:29 +0000 Received: from DM3NAM05FT063.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e51::205) by CO2PR05CA0086.outlook.office365.com (2603:10b6:104:1::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1425.8 via Frontend Transport; Wed, 12 Dec 2018 02:07:29 +0000 Received-SPF: SoftFail (protection.outlook.com: domain of transitioning juniper.net discourages use of 66.129.239.12 as permitted sender) Received: from P-EXFEND-EQX-01.jnpr.net (66.129.239.12) by DM3NAM05FT063.mail.protection.outlook.com (10.152.98.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1446.5 via Frontend Transport; Wed, 12 Dec 2018 02:07:28 +0000 Received: from P-EXBEND-EQX-01.jnpr.net (10.104.8.52) by P-EXFEND-EQX-01.jnpr.net (10.104.8.54) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 11 Dec 2018 18:07:27 -0800 Received: from p-mailhub01.juniper.net (10.104.20.6) by P-EXBEND-EQX-01.jnpr.net (10.104.8.52) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Tue, 11 Dec 2018 18:07:27 -0800 Received: from kaos.jnpr.net (kaos.jnpr.net [172.23.50.162]) by p-mailhub01.juniper.net (8.14.4/8.11.3) with ESMTP id wBC27QqW024125; Tue, 11 Dec 2018 18:07:27 -0800 (envelope-from sjg@juniper.net) Received: by kaos.jnpr.net (Postfix, from userid 1377) id C044E14AF0; Tue, 11 Dec 2018 18:07:26 -0800 (PST) Received: from kaos.jnpr.net (localhost [127.0.0.1]) by kaos.jnpr.net (Postfix) with ESMTP id BE90D14AEF; Tue, 11 Dec 2018 18:07:26 -0800 (PST) To: CC: Devin Teske , src-committers , , , Subject: Re: svn commit: r341803 - head/libexec/rc In-Reply-To: References: <201812110138.wBB1cp1p006660@repo.freebsd.org> <2a76b295-b2da-3015-c201-dbe0ec63ca5a@FreeBSD.org> <98481565-CDD7-4301-B86B-072D5B984AF7@FreeBSD.org> <917251B0-00E0-47E2-B6FB-568EDB9ED781@FreeBSD.org> Comments: In-reply-to: Conrad Meyer message dated "Tue, 11 Dec 2018 17:00:15 -0800." From: "Simon J. Gerraty" X-Mailer: MH-E 8.6+git; nmh 1.7.1; GNU Emacs 26.1 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <43931.1544580446.1@kaos.jnpr.net> Date: Tue, 11 Dec 2018 18:07:26 -0800 Message-ID: <46440.1544580446@kaos.jnpr.net> X-EXCLAIMER-MD-CONFIG: e3cb0ff2-54e7-4646-8a04-0dae4ac7b136 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:66.129.239.12; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10019020)(376002)(346002)(396003)(39860400002)(136003)(2980300002)(189003)(199004)(97736004)(97876018)(2906002)(69596002)(356004)(2351001)(305945005)(6916009)(55016002)(336012)(46406003)(107886003)(186003)(23726003)(6346003)(117636001)(77096007)(53546011)(76176011)(50466002)(7696005)(6266002)(5660300001)(53936002)(6246003)(68736007)(97756001)(90966002)(26005)(14444005)(9686003)(450100002)(8676002)(93886005)(486006)(4326008)(478600001)(76506005)(229853002)(81166006)(81156014)(16586007)(53416004)(11346002)(7126003)(316002)(50226002)(54906003)(126002)(476003)(86362001)(446003)(47776003)(8936002)(106466001)(105596002)(42262002); DIR:OUT; SFP:1102; SCL:1; SRVR:DM5PR05MB3273; H:P-EXFEND-EQX-01.jnpr.net; FPR:; SPF:SoftFail; LANG:en; PTR:InfoDomainNonexistent; MX:1; A:1; X-Microsoft-Exchange-Diagnostics: 1; DM3NAM05FT063; 1:oDOQrmLJbBEu5OM/uZr/CTKNa/+GG/CNGhfp9R0gmVa3t1ttIvzFqScE7XzV+tdIMss/87C6Raq9VqycJMieWUtp8VOmhJghfBYyQBJbzONFqV3V0J/4uLdQIyS0eST4 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: eb944139-0081-45d7-b303-08d65fd691af X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(2390098)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060); SRVR:DM5PR05MB3273; X-Microsoft-Exchange-Diagnostics: 1; DM5PR05MB3273; 3:9W3suadTZvLZQL6/5TGfZBfPQE67TP3b93Pkw3EfOnQ4ef02/JN8ewH8AVOz+hyrO/H4lYd6Cs1wW3+HBeobK3/6EZ7a/mpJAdeNR4Hh+MeF29eEb3kW8W34NTSmbknRBz97T354qfV2wJQIkM02Gn89+UjiJoOnDdV+V0XCVPvOio1ec/JZBYPTcTm9KuBLPB/5z4+vGXTl/Fdjptign264I29r26oha9TexeHg2Kf0wRljkFU4vOIWCGbo+Eqnwho2eOysqe+iuS9xnIyAC719KbYNYFomUOqrB4eKSgtOk2ferhoDq5I+AkJz8/PZEnFXhpX88a66JDPwmIP0lcjolXZV1xh5M/skRCT+C6o=; 25:gZblNdg5CTwDdTvLZfDyKGlitgVR74Fq6vXu/8s5rjG4pWJrQ3AXoLwhdo3BCLqc3rCvZIuUtwUAuCaMcW81s1QtXlgu/vTlNQjfb6PbEzPbhuj62eVXJ/vPj8IvP+qBVzgND/xD4KyAUoZahadcIaphOkj19GJvQW9IDT6oq5Xa1aDMFEJlozztWIvm2KatnzEE7ZPck6VdoAPuxMf21lbI4RmW52dHZZ1H2MLOalxlvUnwUN+mJdyV0dU4XH8boCnchgbWQ7FJmpe8EkcMuzSIOcp0VEbg9YJeXZ5dX70LoXRYJEfYghdgwWbt0oUXZb/Xanjqy/2HbwYUMRahqg== X-MS-TrafficTypeDiagnostic: DM5PR05MB3273: X-Microsoft-Exchange-Diagnostics: 1; DM5PR05MB3273; 31:xai0DMOPHhyYy5PbMnLTf65URiQICXUBmED9Rijhu99s9J6lLcs6EaiPJYhNlXzrktQT83xtUA+S6nYEPhu/O0HzXfjUBeJG6EPiGGusSc46ciEr7Oo1zGsYQ9QH3weHuFyYG/cAaZV1FenVsjYFA/rq0mc6hBd1rD1FlltuBXyMjsaPZquewX3diSJwFNsWItuQnhk5mV8rjNcDsmO3L4zttTcAF7Uiw41yZhbhOv0=; 20:J4CpnK3j4HEqCPrzkmWiYOPkIjq+a6l+LAUH8o5hEzt2aEAExiBzcU33C5KGOcDpiNWX45cR3NkDa0vf6rCKYu9Jn+GEzcfTEZAVxVWzWesG5pFwwOFz2BAZs+NSc3pv/++q8j8F5q102a6REmpEcIxIRhSV+Ws8zaGJEb94lGcXzDlWpM+afU6letDkWCvwIMdf/rwWxno3qn25DAOCHLbhQ9QordUlAbG9xdjgZgScnymsMlLjpjpgWyX5R2lJLADVj8VaSWZapqn2Ns0fYOer9N7CHhT2QVO8ydTdIMdGDO86NLWrnUHw2dcGRq1XjX4QVxRAAeHCa+oIjmmG5iToJrxAfeIImPIyspi5NB5t5BgCCccPEdLNJb+UXB2dUxJAFo3z41t1lkl0l1mgO8xBRxuxVCZ/QDC9/gZn+rZwepIuowNJgFfX2S6NTbRTjRQ5ZtTZQhkGD6wScsMKVPNyGOMriz64OU7VPe8Z9UN3E77thKjqGKwTWarmZIQs X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(3230017)(999002)(6040522)(2401047)(5005006)(8121501046)(3231472)(944501520)(52105112)(93006095)(93003095)(10201501046)(3002001)(6055026)(148016)(149066)(150057)(6041310)(20161123558120)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(201708071742011)(7699051)(76991095); SRVR:DM5PR05MB3273; BCL:0; PCL:0; RULEID:; SRVR:DM5PR05MB3273; X-Microsoft-Exchange-Diagnostics: 1; DM5PR05MB3273; 4:IjPhE6ASGMGN1qGrGryS7AkRHxR9ISkVWjgL9MztsHsqk0LtRUCSH8l84JnKykIZY98ya/KmVyCjiHkYgQdTn6AxLwPBB4YLBxuC6yP0Z15CK40fMpj1xmkGLch+it0MIbhQgw1ND12STU9qMYJGWn4jTjRKGm0IiGe/EC0HGSIxyXqNvUlj9kJMCFJpDDaDWGTww/PP55mjh04A+iz7BB1cCDD2T3gzM6LyV+oQEg6UN5BypLH2jj6HI0LV7pB2Zh4MqcIiqdtm5qDB2wgdGg== X-Forefront-PRVS: 0884AAA693 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR05MB3273; 23:0yJH0SqdJzl2Qm3AE0UjrRlW0k28agyqe+UXOPxrS?= =?us-ascii?Q?D176dMU/VZ1aBFcty5cqBSD84G8EAmqTX+P1XFmUiDT7um2Ew2wQJlPPgu3T?= =?us-ascii?Q?1FoiTHySPdfACf2MW5qO2VoebNEyldWrwYVaIGUPFtLpRsEN41oP+VTB+TvI?= =?us-ascii?Q?H+i4aovSCb0n147Cq3D+ky3k2xtZ6ru6fKwXELyk97Fb1S8nidVBSvO/N0+K?= =?us-ascii?Q?LTBrlklfKX80TWjMcEQdjua9xpKwjj4jd2z/LxuarTMth1183cJnThtgRBoh?= =?us-ascii?Q?xYfj62P0POM1fYA9uaJ2lRf0WrejNtN/MR9mQKgK3mVIznN60tZEystEt3ap?= =?us-ascii?Q?jr03uulvrL6mxtkUuPoijxFt8l/bmvYlDr7MUqdUlAoD+pwERYCu4d0piUIG?= =?us-ascii?Q?4WLKOSBf5tEU9uLnPho8sUMU2f+0yzSgJk5Z3Tw2fNjOQqApd7oep9wQmvI9?= =?us-ascii?Q?5dglJkmKORPMpKXdY7OuLZ4fxnQut63Ikgjy30ShpAgSqhzTxkY/iW3I1Wlf?= =?us-ascii?Q?mKXk1ZcJC0Vcpd4DDWTRWU42CAqisb5k2JoZSh0bPeGEeZydGmKFlSllE862?= =?us-ascii?Q?LAdNhhV4wjGSJ199+gYIirivUc7hxIkJmnKac+Z5wXVNx0bBy0EpuNZFFwmb?= =?us-ascii?Q?cmu9M9CWIMyqypx0X5Y6DONH9puRL3VPmozK2JNxaTQSiCw3eWXIkqcWpRTX?= =?us-ascii?Q?QiX4rYfl4+v5TyWkpBL/m05tCysXukKV5pJ34F4FT4M1b9lFa7drjmZP+kYs?= =?us-ascii?Q?1VCbM2BC8WaS8+4rGDu9om7FN0ZqQc+Kk76rwYJBKm361/A/0O7ZgEGl+GsD?= =?us-ascii?Q?w+O3ZB9ADVxfg++wOwMhj8RlMO4OQCQoTfT9wCUMo0gaVX4ZepoO9UWcGyKN?= =?us-ascii?Q?JDwoxSunchaIlEbiPEK3EZKWAOSYSvHDb8wFpU5/owlDQuueLJJ3aGFht9M7?= =?us-ascii?Q?wNxISKUrkDPJWpfiZ/gdePdbxfNTX74Btm110z2K63gyDH3K/gC08oGKsvti?= =?us-ascii?Q?33TqreR2PO92pRogdb4x26XBCd8tHj1EkRGhId+KQnqf9paf4FfxvWzGoFzq?= =?us-ascii?Q?04mIb5WlPFppr4Z8FxhuQkpz13BvInGFp6j3sET0HvIKFz0hcWQGki/0/Sp9?= =?us-ascii?Q?NCjgAdx6zs0gTIKnqinJVN6+dOJWbRbduIhJ1HTMvcfsfZG+1xl8SH7qLZx1?= =?us-ascii?Q?fIvj+8Jel2qBCSSvvkCRZIr7iVLvH+RzavZNxDYZyn/QjlKtHwyhY8Un88l/?= =?us-ascii?Q?nrDsxl7KbEdiWweSNVBV/EINpGVL8GohqoFdV6AeNBNMOgSFYC8iEZYxVBiz?= =?us-ascii?Q?qSz1seEm+kGTYe/ijEQ75NtQBV3v+KZJd/N3Jwdx1VuqGRD+m2Cz1LPVSqze?= =?us-ascii?Q?PEryX1YkIa+drEmVHec/SrJDpNgPaIBDy8bjGwfsErdaRvV6xHSb9P58S9Na?= =?us-ascii?Q?jJCwePguUm8emUHsb8FAD5m6ZEKoJQ=3D?= X-Microsoft-Antispam-Message-Info: Gif/JTc4RnjlMt6HNJt1MwT5xZ56luGRyXAzk8okGtWhzqq+ebpY5vttFCvlAiJT1xnGzpaR8aDSCzNxJ8SyoslVnSKIuDB+VFC+KUsXUKudk9fiihDNAkBebCfPjwQJ4S4B5Etjxkfj0Rme1qHm+9VkJTDyTFVv1QyQ/df0Ilzrcjc/RFIqcv8oG8/rITQV6FsYK63aQQyhEvOFO+eCQQCR3dKuKry8mUywOl+uxGpq/E2JGbD3xNXM1SbOXMC49o459E/bGI/ijaJCajRfYIN1o2ZA3M3eQH+zTjbjjuYD1gce6ofPzIj5BoJj01Qv X-Microsoft-Exchange-Diagnostics: 1; DM5PR05MB3273; 6:qQ7zcH7H3qZXaXr/uYrhowZnNyEKw0nSFMy9xK9MfWXzIQ1y5RC56spa3orZVs+1e1QX5obo+Vme95wRWyZy487M4NzgjrcDUt78rUoijbPuy0kRjYytQq198zakKecyPGmN0qKozGG+hV10p+WPsi8b1WEFWi92vs4cd3VbwRoYAGRzgSs1ihDH9/6o/F/IQjt/CP1GyIAE5glC04lFSQcnFOyzS14vPA6HA5YoRNtAdTBzpEhee4/B+VWSVvmIvMhsmkTV5OuFI2Ju/NjD0kx2M1sAxpbeQT5eoNVW4GFVAc0b7foGL+bnQkACfC+JTLKDh+mIZSQRv3FpXbSIY/JV8pYsc+LP830uCaLswj0HAilkw+JVYkeD3gMfVy7aKU1ywV6Eozwd86RWWpVFR0o04OdL2P4ZRmJwD3X7CFUWrekvZZofp9cD6QBb2PpI97A93VIioltxt6KdMMBL1w==; 5:GLs3EmberyCaWpq+/cFyOKi4cpr84yYI7FStEMEYHk9MzWyXyv4NoSJGOSX2kPVgtsmvvob2jRGDnKHq3udOGmEsagQMo3Us00PlSqcWmyZ2kRycFVhtPjacopfGQFGXvYZuhRzLIUz0FAg+ikO5VF96j8TSacZzDu2O9JuELUY=; 7:tbv5LLVqDw+zw3SF0Obi1DajGDzaw3oez590cNMYFNdY+jTLMelqhYNCalYO1khLRUuaiitQSMYGyW22xee036xa/VNf2WDZutIECf9/NLeVUOJsMRYiT4CW3yOgIAoQzHHP8D2Rhk9osXCMKx3sCw== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: juniper.net X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Dec 2018 02:07:28.8229 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: eb944139-0081-45d7-b303-08d65fd691af X-MS-Exchange-CrossTenant-Id: bea78b3c-4cdb-4130-854a-1d193232e5f4 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bea78b3c-4cdb-4130-854a-1d193232e5f4; Ip=[66.129.239.12]; Helo=[P-EXFEND-EQX-01.jnpr.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR05MB3273 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2018-12-11_09:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_spam_notspam policy=outbound_spam score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=716 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1812120014 X-Rspamd-Queue-Id: 9C9526C5F9 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-4.94 / 15.00]; NEURAL_HAM_SHORT(-0.94)[-0.945,0]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Dec 2018 02:07:39 -0000 Just caught the tail of this thread so sorry for chiming in from the peanut gallery... blah | while read x; do ...; done behaves very differently to the for loop variant in that the body of the loop runs in a sub-shell and thus cannot affect the outer scope. In many cases that's exactly what you want. Sometimes though, it isn't. Conrad Meyer wrote: > On Tue, Dec 11, 2018 at 2:42 PM Devin Teske wrote: > > In that case, would it be appropriate to say that: > > > > blah | while read x; do ...; done > > > > Is always more efficiently written as: > > > > IFS=$'\n' > > for x in $( blah ); do ...; done > > I don't know. The suggestion came from jilles@, who is much more > familiar with sh(1) than I am. > > My understanding is that it's important that 'set -o noglob' is set, > or else 'blah' lines that include globs may be evaluated against the > filesystem. There is also a caveat if 'blah' is the 'set' command, or > similar, in that IFS' own value itself will be split across multiple > for loop iteration 'x' values ("IFS='", "'"). > > I would hesitate to say "always" given my limited understanding of the > shell, but it might be true.