From owner-freebsd-arm@FreeBSD.ORG Tue Apr 21 17:03:33 2015 Return-Path: Delivered-To: freebsd-arm@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 148C88E3 for ; Tue, 21 Apr 2015 17:03:33 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D23311210 for ; Tue, 21 Apr 2015 17:03:32 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t3LH3Wit085605 for ; Tue, 21 Apr 2015 17:03:32 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t3LH3WCl085601; Tue, 21 Apr 2015 17:03:32 GMT (envelope-from root) Date: Tue, 21 Apr 2015 17:03:32 +0000 To: freebsd-arm@freebsd.org From: "imp (Warner Losh)" Subject: [Differential] [Updated] D2340: Support for Alpine platform from Annapurna Labs Message-ID: X-Priority: 3 Thread-Topic: D2340: Support for Alpine platform from Annapurna Labs X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: MzFmODEzYTliMzhlZDlhOTEyM2NlYTg2YmJiIFU2guQ= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Porting FreeBSD to ARM processors." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Apr 2015 17:03:33 -0000 imp added a comment. Decent start, want to know more about the future of the HAL. Is this a one-off never to be repeated HAL release, or will there be ongoing releases? INLINE COMMENTS sys/arm/annapurna/alpine/alpine_machdep.c:2 Here and elsewhere: is this date right? sys/arm/annapurna/alpine/alpine_machdep.c:165 Perhaps this belongs in the main db_machdep.c? sys/arm/annapurna/alpine/alpine_machdep.c:199 ditto? Both with appropriate #ifdef maybe? sys/arm/annapurna/alpine/alpine_machdep_mp.c:143 Shouldn't this be a kassert? sys/arm/annapurna/alpine/alpine_machdep_mp.c:172 kassert? sys/arm/annapurna/alpine/alpine_pci.c:84 Given how this macro is used in this file, I might be tempted to make it available under bootverbose instead of 'DEBUG' sys/arm/annapurna/alpine/alpine_pci.c:667 ~0 is signed, but this takes an unsigned value. 0xfffffffful is likely a better match. sys/arm/annapurna/alpine/alpine_pci.c:1097 Why enable these explicitly here? Drivers are supposed to do so... sys/arm/annapurna/alpine/alpine_pci.c:1138 but here it's OK since the bridge is supposed to do this on enable... sys/arm/annapurna/alpine/alpine_pci.c:1372 why do this if it is unused? sys/arm/annapurna/alpine/alpine_pci.c:1378 ~3 seems magic. sys/arm/annapurna/alpine/alpine_pci.c:1387 Most places use NBBY instead of a bare 8 for 8 bits in a byte. sys/arm/annapurna/alpine/alpine_pci.c:1412 why get it? sys/arm/annapurna/alpine/hal/al_hal_iofic.h:1 For the HAL files, will we need to worry about updates? For Octeon/Cavium, we imported their SDK/HAL routines separately. Does it make sense to do that here? REVISION DETAIL https://reviews.freebsd.org/D2340 To: jpa-semihalf.com, ian, andrew, imp Cc: freebsd-arm