From owner-freebsd-git@freebsd.org  Thu Feb 18 16:53:12 2021
Return-Path: <owner-freebsd-git@freebsd.org>
Delivered-To: freebsd-git@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1675353FC66
 for <freebsd-git@mailman.nyi.freebsd.org>;
 Thu, 18 Feb 2021 16:53:12 +0000 (UTC) (envelope-from jhb@FreeBSD.org)
Received: from smtp.freebsd.org (smtp.freebsd.org
 [IPv6:2610:1c1:1:606c::24b:4])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4DhLPN09Cvz4p1x;
 Thu, 18 Feb 2021 16:53:12 +0000 (UTC) (envelope-from jhb@FreeBSD.org)
Received: from John-Baldwins-MacBook-Pro.local (unknown
 [IPv6:2601:648:8681:1cb0:f03d:5bcf:93a2:4bfa])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client did not present a certificate) (Authenticated sender: jhb)
 by smtp.freebsd.org (Postfix) with ESMTPSA id A390E7E9F;
 Thu, 18 Feb 2021 16:53:11 +0000 (UTC) (envelope-from jhb@FreeBSD.org)
Subject: Re: Adopting "Fixes" trailer
To: Ed Maste <emaste@freebsd.org>, freebsd-git <freebsd-git@freebsd.org>
References: <CAPyFy2BbjPZgkcLLRNNA-y19tpyYBKOT6FN8JNX4=hmDSdScLw@mail.gmail.com>
From: John Baldwin <jhb@FreeBSD.org>
Message-ID: <75c9ad1e-c7ca-8a22-cfe5-6434b3685ccc@FreeBSD.org>
Date: Thu, 18 Feb 2021 08:53:09 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0)
 Gecko/20100101 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: <CAPyFy2BbjPZgkcLLRNNA-y19tpyYBKOT6FN8JNX4=hmDSdScLw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-BeenThere: freebsd-git@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Discussion of git use in the FreeBSD project <freebsd-git.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-git>,
 <mailto:freebsd-git-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-git/>
List-Post: <mailto:freebsd-git@freebsd.org>
List-Help: <mailto:freebsd-git-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-git>,
 <mailto:freebsd-git-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Feb 2021 16:53:12 -0000

On 2/17/21 8:31 AM, Ed Maste wrote:
> In review D28693 I've proposed adding a "Fixes" trailer to the commit
> message template. It is used to identify a commit that is a follow-up bug
> fix to a previous commit, and could generally be used instead of "MFC with"
> or "X-MFC-with". One nice aspect is that it conveys fix metadata also for
> commits that aren't intended for MFC, which may be useful for downstream
> projects.
> 
> Fixes is already used by a number of other projects. I have proposed adding
> to the template
> # Fixes: <Short hash and title line of commit fixed by this change>
> 
> Please follow up here or in the review with any comments. I'll commit in a
> few days if there are no objections.
> 
> https://reviews.freebsd.org/D28693

Huh, at first I thought this was to auto-close issues on GitHub.  I think
this is a good idea.  If we had a wrapper script for MFC's it could
auto-squash those as an option perhaps.

-- 
John Baldwin