From owner-cvs-all Sat Sep 22 6:18:12 2001 Delivered-To: cvs-all@freebsd.org Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by hub.freebsd.org (Postfix) with ESMTP id C545F37B408; Sat, 22 Sep 2001 06:18:06 -0700 (PDT) Received: (from ache@localhost) by nagual.pp.ru (8.11.6/8.11.6) id f8MDI5C84381; Sat, 22 Sep 2001 17:18:05 +0400 (MSD) (envelope-from ache) Date: Sat, 22 Sep 2001 17:18:03 +0400 From: "Andrey A. Chernov" To: Robert Watson Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libutil login.conf.5 login_cap.c Message-ID: <20010922171802.A84301@nagual.pp.ru> References: <200109161648.f8GGmeU75597@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200109161648.f8GGmeU75597@freefall.freebsd.org> User-Agent: Mutt/1.3.21i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, Sep 16, 2001 at 09:48:40 -0700, Robert Watson wrote: > rwatson 2001/09/16 09:48:40 PDT > > Modified files: > lib/libutil login.conf.5 login_cap.c > Log: > Disable per-user .login_conf support due to incorrect merging of local > and globaly settings. An alternative implementation will be developed. > > Reported by: Przemyslaw Frasunek Please back it out. The bug reported not affects FreeBSD-current. We already have alternative implementation in FreeBSD-current, so nothing needs to be disabled here or developed. It seems you not test reported bug in FreeBSD-current. Only "me" login class is picked from ~/.login_conf, anything else like "default" or "standard" are ignored here. When "me" class picked, it picked from user priveledges. And even when "me" class is picked, it can't override "copyright" and "welcome" properties, so we are triple safe. Proper move will be not disabling anything but MFC FreeBSD-current login_cap implementation to other branches. -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message