From owner-cvs-all Sun Feb 17 12:30:45 2002 Delivered-To: cvs-all@freebsd.org Received: from green.bikeshed.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 59D4F37B405; Sun, 17 Feb 2002 12:30:25 -0800 (PST) Received: from localhost (green@localhost) by green.bikeshed.org (8.11.6/8.11.6) with ESMTP id g1HKUOs01319; Sun, 17 Feb 2002 15:30:24 -0500 (EST) (envelope-from green@green.bikeshed.org) Message-Id: <200202172030.g1HKUOs01319@green.bikeshed.org> X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Poul-Henning Kamp Cc: Brian Feldman , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_conf.c src/sys/sys conf.h In-Reply-To: Message from Poul-Henning Kamp of "Sun, 17 Feb 2002 21:08:16 +0100." <5581.1013976496@critter.freebsd.dk> From: "Brian F. Feldman" Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sun, 17 Feb 2002 15:30:24 -0500 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Poul-Henning Kamp wrote: > In message <200202161735.g1GHZ5N03909@freefall.freebsd.org>, Brian Feldman writ > es: > >green 2002/02/16 09:35:05 PST > > > > Modified files: > > sys/kern kern_conf.c > > sys/sys conf.h > > Log: > > Add revoke_and_destroy_dev(), to be used by devices which decide when > > they choose to destroy themselves without regard to whether or not > > they are open. > > Hmm, I can see the point but I am not 100% convinced about the > solution, I may modify this API later. I had in my tree a dev_revoke() call which I used at times, previously, which IIRC was just the first part of that function, to be called before a destroy_dev() when a driver's decided a removeable device had gone away. I like the combination of the two functions because it serves to document what's going on pretty well, but have no strong attachment; I'll be happy to start sprinkling either around the src/sys tree where appropriate. I should compile a list of places in the kernel where it should be used other than the initial one I have it used for locally. -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org <> bfeldman@tislabs.com \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message