From owner-svn-src-all@FreeBSD.ORG Tue Jun 18 13:30:37 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 7B8DE37D for ; Tue, 18 Jun 2013 13:30:37 +0000 (UTC) (envelope-from mcdouga9@egr.msu.edu) Received: from mail.egr.msu.edu (hill.egr.msu.edu [35.9.37.162]) by mx1.freebsd.org (Postfix) with ESMTP id 5714819C2 for ; Tue, 18 Jun 2013 13:30:36 +0000 (UTC) Received: from hill (localhost [127.0.0.1]) by mail.egr.msu.edu (Postfix) with ESMTP id A773A3E599 for ; Tue, 18 Jun 2013 09:30:35 -0400 (EDT) X-Virus-Scanned: amavisd-new at egr.msu.edu Received: from mail.egr.msu.edu ([127.0.0.1]) by hill (hill.egr.msu.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nW_kV__KD3KP for ; Tue, 18 Jun 2013 09:30:35 -0400 (EDT) Received: from EGR authenticated sender Message-ID: <51C060FB.1020209@egr.msu.edu> Date: Tue, 18 Jun 2013 09:30:35 -0400 From: Adam McDougall User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130516 Thunderbird/17.0.6 MIME-Version: 1.0 To: svn-src-all@freebsd.org Subject: Re: svn commit: r251297 - head/sys/dev/xen/netfront References: <201306031300.r53D0XUx092178@svn.freebsd.org> In-Reply-To: <201306031300.r53D0XUx092178@svn.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Jun 2013 13:30:37 -0000 On 06/03/13 09:00, Andre Oppermann wrote: > Author: andre > Date: Mon Jun 3 13:00:33 2013 > New Revision: 251297 > URL: http://svnweb.freebsd.org/changeset/base/251297 > > Log: > Specify a maximum TSO length limiting the segment chain to what the > Xen host side can handle after defragmentation. > > This prevents the driver from throwing away too long TSO chains and > improves the performance on Amazon AWS instances with 10GigE virtual > interfaces to the normally expected throughput. > > Submitted by: cperciva (earlier version) > Reviewed by: cperciva > Tested by: cperciva > MFC after: 1 week > > Modified: > head/sys/dev/xen/netfront/netfront.c > > Modified: head/sys/dev/xen/netfront/netfront.c > ============================================================================== > --- head/sys/dev/xen/netfront/netfront.c Mon Jun 3 12:55:13 2013 (r251296) > +++ head/sys/dev/xen/netfront/netfront.c Mon Jun 3 13:00:33 2013 (r251297) > @@ -134,6 +134,7 @@ static const int MODPARM_rx_flip = 0; > * to mirror the Linux MAX_SKB_FRAGS constant. > */ > #define MAX_TX_REQ_FRAGS (65536 / PAGE_SIZE + 2) > +#define NF_TSO_MAXBURST ((IP_MAXPACKET / PAGE_SIZE) * MCLBYTES) > > #define RX_COPY_THRESHOLD 256 > > @@ -2122,6 +2123,7 @@ create_netdev(device_t dev) > > ifp->if_hwassist = XN_CSUM_FEATURES; > ifp->if_capabilities = IFCAP_HWCSUM; > + ifp->if_hw_tsomax = NF_TSO_MAXBURST; > > ether_ifattach(ifp, np->mac); > callout_init(&np->xn_stat_ch, CALLOUT_MPSAFE); Can this and r251296 be MFC'ed yet or does it need more work to pass muster? Thinking ahead to my next deployment build. Thanks.