From owner-freebsd-commit Wed Apr 5 23:45:29 1995 Return-Path: commit-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id XAA12152 for commit-outgoing; Wed, 5 Apr 1995 23:45:29 -0700 Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id XAA12131 for cvs-ports-outgoing; Wed, 5 Apr 1995 23:45:23 -0700 Received: from time.cdrom.com (time.cdrom.com [192.216.223.46]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id XAA12118 ; Wed, 5 Apr 1995 23:45:19 -0700 Received: from vinkku.hut.fi (vinkku.hut.fi [130.233.245.1]) by time.cdrom.com (8.6.11/8.6.9) with ESMTP id XAA10630; Wed, 5 Apr 1995 23:45:13 -0700 Received: (from vode@localhost) by vinkku.hut.fi (8.6.11/8.6.7) id JAA25387; Thu, 6 Apr 1995 09:44:40 +0300 Date: Thu, 6 Apr 1995 09:44:40 +0300 From: Kai Vorma Message-Id: <199504060644.JAA25387@vinkku.hut.fi> To: "Jordan K. Hubbard" Cc: "Rodney W. Grimes" , jkh@freebsd.org (Jordan K. Hubbard), CVS-commiters@time.cdrom.com, cvs-ports@time.cdrom.com Subject: Re: cvs commit: ports/net/sup/patches patch-ae In-Reply-To: <11471.797149153@freefall.cdrom.com> References: <199504051810.LAA00954@gndrsh.aac.dev.com> <11471.797149153@freefall.cdrom.com> Reply-To: Kai.Vorma@hut.fi Sender: commit-owner@freebsd.org Precedence: bulk Jordan K. Hubbard writes: > 1. Sorry, I thought he'd changed the manpage. I'll document it if he > doesn't beat me to it. Do it, please. My english is far from perfect.. > 2. You turn it off by not creating a file with the special name.. :-) Jup. I thought about adding some flag for it, but consider: 1) a flag that turns it on? You forget once that flag and all your local modifications are gone :-( 2) a flag that turns it off? Why? Just rename all #sup files back to normal. Of course sup could do that for you but I tried to keep it simple. > 3. You would prefer that he simply not admit to the hackery? ;-) :-) I admit the patch wasn't very pretty. Sup itself is quite a mess (much of nice globals and interesting code-paths etc.) so I just decided to make as few modifications as possible. ..vode