Date: Tue, 19 May 2015 15:23:54 -0600 From: Adam Weinberger <adamw@adamw.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: Baptiste Daroussin <bapt@FreeBSD.org>, "Vanilla I. Shu" <vanilla@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r386737 - in head/security: . tmux-cssh Message-ID: <EAAB1B87-F0BD-407A-B824-DC02F815FDD3@adamw.org> In-Reply-To: <38D41B521FF4590990C78FD2@atuin.in.mat.cc> References: <201505190333.t4J3X7BS037914@svn.freebsd.org> <20150519160457.GD52236@ivaldir.etoilebsd.net> <FD67623A-F9A7-4A78-918A-DF700A1C5D0D@adamw.org> <38D41B521FF4590990C78FD2@atuin.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 19 May, 2015, at 15:15, Mathieu Arnold <mat@FreeBSD.org> wrote: >=20 >=20 >=20 > +--On 19 mai 2015 10:15:36 -0600 Adam Weinberger <adamw@adamw.org> = wrote: > |> On 19 May, 2015, at 10:04, Baptiste Daroussin <bapt@FreeBSD.org> = wrote: > |>=20 > |> On Tue, May 19, 2015 at 03:33:07AM +0000, Vanilla I. Shu wrote: > |>> Author: vanilla > |>> Date: Tue May 19 03:33:06 2015 > |>> New Revision: 386737 > |>> URL: https://svnweb.freebsd.org/changeset/ports/386737 > |>>=20 > |>>=20 > |>> +RUN_DEPENDS=3D ${LOCALBASE}/bin/tmux:${PORTSDIR}/sysutils/tmux > |> The dependency is wrong it should be tmux:${PORTSDIR}/sysutils/tmux > |>=20 > |> Best regards, > |> Bapt > |=20 > | I've seen that construct popping up a lot lately. I suspect that the > | problem is that > | = https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefi > | le-depend.html lists ${LOCALBASE}/.../ as the first example. > |=20 > | Perhaps it would be helpful to add something saying "Only include an > | absolute path if the binary is outside of $PATH, or if the binary = also > | exists in base and you specifically want the ports tree version." >=20 > There's a note afterwards saying it, but you're right, there should be = an > example with only a binary in the path first. It says to use full path when it's not in $PATH. What it doesn't say is = to use full path ONLY when it's not in $PATH :-) # Adam --=20 Adam Weinberger adamw@adamw.org http://www.adamw.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?EAAB1B87-F0BD-407A-B824-DC02F815FDD3>