From owner-freebsd-emulation@FreeBSD.ORG Wed Jan 26 23:19:58 2011 Return-Path: Delivered-To: freebsd-emulation@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 408C0106566B; Wed, 26 Jan 2011 23:19:58 +0000 (UTC) (envelope-from decke@FreeBSD.org) Received: from groupware.itac.at (groupware.itac.at [91.205.172.99]) by mx1.freebsd.org (Postfix) with ESMTP id C5E6E8FC08; Wed, 26 Jan 2011 23:19:57 +0000 (UTC) Received: from home.bluelife.at (93.104.210.95) by groupware.itac.at (Axigen) with (AES256-SHA encrypted) ESMTPSA id 14BA37; Thu, 27 Jan 2011 00:22:01 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Date: Thu, 27 Jan 2011 00:19:57 +0100 From: Bernhard Froehlich To: Mikolaj Golub In-Reply-To: <8662tbkahz.fsf@zhuzha.ua1> References: <86oc77heqk.fsf@kopusha.home.net> <4D3D2DE9.2060004@freebsd.org> <86tygwy9p0.fsf@kopusha.home.net> <4D3F8357.2070005@freebsd.org> <62fcd16074e526547c3417a8f259174e@bluelife.at> <8662tbkahz.fsf@zhuzha.ua1> Message-ID: X-Sender: decke@FreeBSD.org User-Agent: Roundcube Webmail/0.5-rc X-AxigenSpam-Level: 1 X-CTCH-RefID: str=0001.0A0B0202.4D40AC1C.00A2,ss=1,fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown Cc: freebsd-emulation@freebsd.org, Julian Elischer , freebsd-virtualization@freebsd.org Subject: Re: VirtualBox + VIMAGE X-BeenThere: freebsd-emulation@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Development of Emulators of other operating systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Jan 2011 23:19:58 -0000 On Wed, 26 Jan 2011 16:25:28 +0200, Mikolaj Golub wrote: > On Wed, 26 Jan 2011 10:22:40 +0100 Bernhard Froehlich wrote: > > BF> Sounds like it's my turn now. Which FreeBSD version is required to be > BF> able to use it? > > As Bjoern noted it is for __FreeBSD_version >= 800500. > > BF> Is VIMAGE enabled per default and what happens if VIMAGE is disabled - > BF> does it at least build fine with that patch? > > We have VIMAGE disabled by default. > > I have added to src/VBox/HostDrivers/VBoxNetFlt/freebsd/Makefile: > > .if defined(VIMAGE) > CFLAGS += -DVIMAGE > .endif > > So to build the driver for VIMAGE enabled kernel one should run > > VIMAGE=1 make > > If VIMAGE variable is not defined the module for VIMAGE disabled kernel will > be built. http://home.bluelife.at/patches/virtualbox-ose-kmod-devel-VIMAGE.diff I've integrated it a bit better into the VirtualBox build system, added the ports stuff and updated the patch for VirtualBox 4.0.2. It is currently unclear to me why you add VIMAGE to CFLAGS but nowhere check for VIMAGE in VBoxNetFlt-freebsd.c. Shouldn't we add a check for VIMAGE in the #if defined line or is this already done somewhere deep in the included headers? -- Bernhard Froehlich http://www.bluelife.at/