From owner-svn-ports-all@freebsd.org  Tue Jan 23 15:18:18 2018
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1DCFFED8B61;
 Tue, 23 Jan 2018 15:18:18 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 1135C817A0;
 Tue, 23 Jan 2018 15:18:16 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 5B167A04D; Tue, 23 Jan 2018 15:18:11 +0000 (UTC)
Date: Tue, 23 Jan 2018 15:18:11 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Alex Dupre <ale@FreeBSD.org>
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
Subject: Re: svn commit: r459751 - in head/lang: . solidity solidity/files
Message-ID: <20180123151811.GA68777@FreeBSD.org>
References: <201801231358.w0NDwMa8074241@repo.freebsd.org>
 <20180123140938.GA73049@FreeBSD.org>
 <57ffd7bd-6a3f-b315-b582-17d9dccee5a8@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <57ffd7bd-6a3f-b315-b582-17d9dccee5a8@FreeBSD.org>
User-Agent: Mutt/1.9.2 (2017-12-15)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Jan 2018 15:18:18 -0000

On Tue, Jan 23, 2018 at 03:31:03PM +0100, Alex Dupre wrote:
> Alexey Dokuchaev wrote:
> >> +COMMENT=	Solidity Contract-Oriented Programming Language
> > 
> > COMMENT=	Contract-oriented programming language
> 
> Come on, then the comment for the scala port should be "Programming
> Language"?

`lang/scala's COMMENT is also quite bad.  It is not an excuse to add
more bad and excessively-cap'ed COMMENTs.

> >> +OPTIONS_DEFINE=	SMT
> >> +SMT_DESC=	SMT Checker
> >> +SMT_LIB_DEPENDS=libz3.so:math/z3
> >> +
> >> +USES=		cmake
> > 
> > Misplaced USES.
> 
> I don't see what's misplaced here, portlint doesn't seem to agree with you.

OPTIONS blocks should come last, right before the targets.

> >> +CMAKE_ARGS+=	-DUSE_LD_GOLD=OFF -DTESTS=OFF \
> >> +		-DJSONCPP_INCLUDE_DIR:STRING="${LOCALBASE}/include/jsoncpp" \
> >> +		-DJSONCPP_LIB_DIR:STRING="${LOCALBASE}/lib"
> > 
> > And CMAKE_ARGS (also bogus +=).
> 
> Really?

Yes: I don't see the reason for amending CMAKE_ARGS here; it's not a slave
port or something.  Straight assignment is both appropriate and does not
raise questions (e.g. "why CMAKE_ARGS has to be added to here, am I missing
something"?).

> >> +pre-patch:
> >> +		@${CP} ${FILESDIR}/jsoncpp.cmake ${WRKSRC}/cmake/
> >> +		@${REINPLACE_CMD} '/EthCcache/d' ${WRKSRC}/CMakeLists.txt
> > 
> > Excessive indentation of target recipe (commands).
> 
> Seriously?

Of course.  Target recipes are indented with single tab in most of the
ports, why would you want to break the consistency?

./danfe