From owner-freebsd-arch@FreeBSD.ORG  Thu May 29 05:45:41 2014
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: freebsd-arch@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 34E3F3BE;
 Thu, 29 May 2014 05:45:41 +0000 (UTC)
Received: from mail-qg0-x230.google.com (mail-qg0-x230.google.com
 [IPv6:2607:f8b0:400d:c04::230])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id D68C92EDF;
 Thu, 29 May 2014 05:45:40 +0000 (UTC)
Received: by mail-qg0-f48.google.com with SMTP id i50so20797126qgf.7
 for <multiple recipients>; Wed, 28 May 2014 22:45:39 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date:message-id:subject
 :from:to:cc:content-type;
 bh=Mo7arnjoVsz4fJ3URHK+mq9NBtJeoibAZBwL4rckS98=;
 b=oH8vDCuq3OP7Ftc0CqPwoRDHJny2H647ONYNbvT0AWm2J+yzoAAFbLyc2jaznk4SwM
 pWf3M/pZ62JUAYdnFJJXcBbxIAlGx1iq/5wYXye5G7SVOwfm9nUmvOx7EjTmqqMm8FI7
 58Bv8JErTxPo9U85v8I6bAx8tUe8+PXKo1N+pxDpttHx7QyNNQBEhSTUB3d23mX1zrS7
 dRaj9Gd3dGFvWMSYL0rMA8Zm/s8a1MCkjTRPo6JwoOJzH64rhq7LHsyok4t49wqw4XgW
 ZqhwNbphYSz+1AngQt0A5bk0NZricdv7bGaJBJVOTL/q29ZmLwghe3oQX8AmOTl+or1N
 NjUA==
MIME-Version: 1.0
X-Received: by 10.224.16.199 with SMTP id p7mr6600737qaa.76.1401342339706;
 Wed, 28 May 2014 22:45:39 -0700 (PDT)
Sender: adrian.chadd@gmail.com
Received: by 10.224.191.201 with HTTP; Wed, 28 May 2014 22:45:39 -0700 (PDT)
In-Reply-To: <FA49AADC-A853-49F0-B80C-F0FBA1219177@xcllnt.net>
References: <FA49AADC-A853-49F0-B80C-F0FBA1219177@xcllnt.net>
Date: Wed, 28 May 2014 22:45:39 -0700
X-Google-Sender-Auth: eJdjCt64-H8Ok814Veh0UEHC9WQ
Message-ID: <CAJ-VmonPP3Sbc+1GuUxgjQhwTEaHPHMO72V6JVuq2CMpiMutbA@mail.gmail.com>
Subject: Re: Roadmap for ifnet(9) for FreeBSD 11
From: Adrian Chadd <adrian@freebsd.org>
To: Marcel Moolenaar <marcel@xcllnt.net>
Content-Type: text/plain; charset=UTF-8
Cc: Anuranjan Shukla <anshukla@juniper.net>,
 Gleb Smirnoff <glebius@freebsd.org>,
 "freebsd-arch@FreeBSD.org Arch" <freebsd-arch@freebsd.org>
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch/>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 29 May 2014 05:45:41 -0000

Hi!


On 28 May 2014 09:34, Marcel Moolenaar <marcel@xcllnt.net> wrote:
> All,

> Since Juniper already has a working patch that achieves the
> objective of making ifnet an opaque type by replacing ifnet
> pointer dereferences with function calls in an almost mechanical
> fashion, we propose to merge that first.
> The patch doesn't break old-style access to struct ifnet, which
> means that unconverted and converted drivers coexist. This gives
> us time to convert drivers. This also gives Juniper an important
> rendezvous point between their and our repos.

Hi!

Converting all the ifnet dereferencing and converting it to accessor
functions/macros seems like a no-brainer pass. You can do this without
necessarily converting them to void *. That can be a separate pass.

i wonder about the immediate benefits of making it fully opaque versus
"mostly opaque-ready for you." Would we get less formalish checking
coverage with static analysis tools and the compiler?


-a