From owner-cvs-src@FreeBSD.ORG Fri Feb 25 19:38:19 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 967BD16A4CE; Fri, 25 Feb 2005 19:38:19 +0000 (GMT) Received: from ebb.errno.com (ebb.errno.com [66.127.85.87]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5A6A843D58; Fri, 25 Feb 2005 19:38:19 +0000 (GMT) (envelope-from sam@errno.com) Received: from [66.127.85.91] (sam@[66.127.85.91]) (authenticated bits=0) by ebb.errno.com (8.12.9/8.12.6) with ESMTP id j1PJcIWi028463 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 25 Feb 2005 11:38:18 -0800 (PST) (envelope-from sam@errno.com) Message-ID: <421F7ED9.9050009@errno.com> Date: Fri, 25 Feb 2005 11:39:05 -0800 From: Sam Leffler User-Agent: Mozilla Thunderbird 1.0RC1 (X11/20041208) X-Accept-Language: en-us, en MIME-Version: 1.0 To: src-committers@FreeBSD.org References: <200502251934.j1PJYBQf002457@repoman.freebsd.org> In-Reply-To: <200502251934.j1PJYBQf002457@repoman.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/compat/svr4 svr4_signal.c svr4_signal.h svr4_sysvec.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Feb 2005 19:38:19 -0000 Sam Leffler wrote: > sam 2005-02-25 19:34:11 UTC > > FreeBSD src repository > > Modified files: > sys/compat/svr4 svr4_signal.c svr4_signal.h svr4_sysvec.c > Log: > fixup signal mapping: > o change the mapping arrays to have a zero offset rather than base 1; > this eliminates lots of signo adjustments and brings the code > back inline with the original netbsd code > o purge use of SVR4_SIGTBLZ; SVR4_NSIG is the only definition for > how big a mapping array is > o change the mapping loops to explicitly ignore signal 0 > o purge some bogus code from bsd_to_svr4_sigset > o adjust svr4_sysentvec to deal with the mapping table change > > Enticed into fixing by: Coverity Prevent analysis tool > Glanced at by: marcel, jhb Note that I do not have an svr4 binaries to run to test these changes. I wrote some test applications to verify the signal mapping logic but if someone can vet these changes with real use I'd appreciate it. FWIW all this came about because the Coverity tool pointed out an invalid array index that led me into this tarpit. Sam