From owner-cvs-all Thu Sep 2 6: 6:44 1999 Delivered-To: cvs-all@freebsd.org Received: from grisu.bik-gmbh.de (grisu.bik-gmbh.de [194.233.237.82]) by hub.freebsd.org (Postfix) with ESMTP id 7F09914E41; Thu, 2 Sep 1999 06:06:36 -0700 (PDT) (envelope-from cracauer@gilgamesch.bik-gmbh.de) Received: from gilgamesch.bik-gmbh.de (gilgamesch.bik-gmbh.de [194.233.237.194]) by grisu.bik-gmbh.de (8.8.8/8.6.9) with ESMTP id PAA04328; Thu, 2 Sep 1999 15:04:52 +0200 (MEST) Received: (from cracauer@localhost) by gilgamesch.bik-gmbh.de (8.9.3/8.7.3) id PAA65832; Thu, 2 Sep 1999 15:04:52 +0200 (MET DST) Date: Thu, 2 Sep 1999 15:04:52 +0200 From: Martin Cracauer To: Bill Fumerola Cc: "Rodney W. Grimes" , Michael Haro , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/bin/mkdir mkdir.1 mkdir.c Message-ID: <19990902150452.A63833@cons.org> References: <199908282102.OAA60244@gndrsh.dnsmgr.net> <19990830091345.B90785@cons.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.95.4i In-Reply-To: <19990830091345.B90785@cons.org>; from Martin Cracauer on Mon, Aug 30, 1999 at 09:13:45AM +0200 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk > The vflag should be local to main() and explicitly initialized to zero > to be consistent with the initialization of omode and pflag. Why > doesn't the `v` work together with the `m` flag? Is it useful just to > print the directory name in that case. Shouldn't the mode be echoed as > well? I sorry to add to this thread again, but... ... the fact that these code quality concerns has neither been corrected nor even answered, at a time where committer rules are being discussed and broken, in a thread that should have stopped followup committs that were made, is irritating and leaves me with a bad impression of the committer. Martin -- %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% Martin Cracauer http://www.cons.org/cracauer/ BSD User Group Hamburg, Germany http://www.bsdhh.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message