From owner-svn-src-all@freebsd.org  Sun Nov 15 14:28:27 2015
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id B37ACA2F05C
 for <svn-src-all@mailman.ysv.freebsd.org>;
 Sun, 15 Nov 2015 14:28:27 +0000 (UTC) (envelope-from ian@freebsd.org)
Received: from outbound1b.ore.mailhop.org (outbound1b.ore.mailhop.org
 [54.200.247.200])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 938C11237
 for <svn-src-all@freebsd.org>; Sun, 15 Nov 2015 14:28:27 +0000 (UTC)
 (envelope-from ian@freebsd.org)
Received: from ilsoft.org (unknown [73.34.117.227])
 by outbound1.ore.mailhop.org (Halon Mail Gateway) with ESMTPSA;
 Sun, 15 Nov 2015 14:27:32 +0000 (UTC)
Received: from rev (rev [172.22.42.240])
 by ilsoft.org (8.14.9/8.14.9) with ESMTP id tAFERIQa010128;
 Sun, 15 Nov 2015 07:27:18 -0700 (MST) (envelope-from ian@freebsd.org)
Message-ID: <1447597638.1254.16.camel@freebsd.org>
Subject: Re: svn commit: r290840 - head/etc
From: Ian Lepore <ian@freebsd.org>
To: Garrett Cooper <ngie@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Date: Sun, 15 Nov 2015 07:27:18 -0700
In-Reply-To: <201511150304.tAF34dD2062713@repo.freebsd.org>
References: <201511150304.tAF34dD2062713@repo.freebsd.org>
Content-Type: text/plain; charset="us-ascii"
X-Mailer: Evolution 3.16.5 FreeBSD GNOME Team Port 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 15 Nov 2015 14:28:27 -0000

On Sun, 2015-11-15 at 03:04 +0000, Garrett Cooper wrote:
> Author: ngie
> Date: Sun Nov 15 03:04:39 2015
> New Revision: 290840
> URL: https://svnweb.freebsd.org/changeset/base/290840
> 
> Log:
>   Setup the symlink to /sys to mirror one's current source, e.g. if
> my source
>   tree was /usr/src/svn, /sys would point to usr/src/svn
>   
>   This fixes the assumption that the source tree will always exist at
>   ${DESTDIR}/usr/src
>   
>   MFC after: 1 week
>   PR: 76362
>   Reported by: Scot Hetzel <swhetzel@gmail.com>
>   Sponsored by: EMC / Isilon Storage Division
> 
> Modified:
>   head/etc/Makefile
> 
> Modified: head/etc/Makefile
> =====================================================================
> =========
> --- head/etc/Makefile	Sun Nov 15 01:50:17 2015	(r290839
> )
> +++ head/etc/Makefile	Sun Nov 15 03:04:39 2015	(r290840
> )
> @@ -408,7 +408,7 @@ distrib-dirs: ${MTREES:N/*} distrib-clea
>  		    ${METALOG.add} ; \
>  	done; true
>  .endif
> -	${INSTALL_SYMLINK} usr/src/sys ${DESTDIR}/sys
> +	${INSTALL_SYMLINK} ${SRCTOP:C/^\///}/sys ${DESTDIR}/sys
>  .if ${MK_MAN} != "no"
>  	cd ${DESTDIR}${SHAREDIR}/man; \
>  	for mandir in man*; do \
> 

This might make some sense if DESTDIR is empty or /, but with most uses
of non-empty DESTDIR this is just going to make a symlink to some
random place that likely won't even exist on the running system.  If
source code is later installed to that DESTDIR as well, the /sys link
will just be broken in a way that's likely to lead to very confusing
errors.

-- Ian