From owner-cvs-all@FreeBSD.ORG Wed Nov 17 22:43:37 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3F76B16A4CE; Wed, 17 Nov 2004 22:43:37 +0000 (GMT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 202A643D49; Wed, 17 Nov 2004 22:43:36 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id iAHMhZAk050339; Thu, 18 Nov 2004 00:43:35 +0200 (EET) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 86952-04; Thu, 18 Nov 2004 00:43:34 +0200 (EET) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id iAHMhYdJ050336 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 18 Nov 2004 00:43:34 +0200 (EET) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.1/8.13.1) id iAHMhaeS067758; Thu, 18 Nov 2004 00:43:36 +0200 (EET) (envelope-from ru) Date: Thu, 18 Nov 2004 00:43:36 +0200 From: Ruslan Ermilov To: John-Mark Gurney , Bruce Evans Message-ID: <20041117224336.GC1562@ip.net.ua> References: <200411172135.iAHLZNfR098453@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="96YOpH+ONegL0A3E" Content-Disposition: inline In-Reply-To: <200411172135.iAHLZNfR098453@repoman.freebsd.org> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new at ip.net.ua cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci if_sk.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Nov 2004 22:43:37 -0000 --96YOpH+ONegL0A3E Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 17, 2004 at 09:35:23PM +0000, John-Mark Gurney wrote: > jmg 2004-11-17 21:35:22 UTC >=20 > FreeBSD src repository >=20 > Modified files: > sys/pci if_sk.c=20 > Log: > only clear the IFF_OACTIVE flag when we have a chance of being able to > queue a packet to the hardware... instead of when the hardware queue is > empty.. > =20 > don't initalize cur_tx now that it doesn't need to be... > =20 > Pointed out by: bde > =20 > Revision Changes Path > 1.92 +4 -4 src/sys/pci/if_sk.c >=20 Wrong wording. The correct wording would be: > clear the IFF_OACTIVE flag AS SOON AS we have a chance of being > able to queue a packet to the hardware... instead of ONLY when > the hardware TX queue is empty.. My old patch (that I didn't commit due to the lack of h/w), resets IFF_OACTIVE inside the while() loop, like this: sc_if->sk_cdata.sk_tx_cnt--; + ifp->if_flags &=3D ~IFF_OACTIVE; SK_INC(idx, SK_TX_RING_CNT); I believe this is more correct than what got committed, but I cannot prove it. ;) Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --96YOpH+ONegL0A3E Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBm9QYqRfpzJluFF4RAkgZAJ9GdwW0oDSyNwvU9ePO+XpdKyUCRACfZUYd W2kzqba+Zlz1QrH+EXExDEI= =4H9x -----END PGP SIGNATURE----- --96YOpH+ONegL0A3E--