From owner-freebsd-arm@freebsd.org Thu Jan 28 01:11:28 2016 Return-Path: Delivered-To: freebsd-arm@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7B656A70379 for ; Thu, 28 Jan 2016 01:11:28 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from mail-ob0-x233.google.com (mail-ob0-x233.google.com [IPv6:2607:f8b0:4003:c01::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4109A181E for ; Thu, 28 Jan 2016 01:11:28 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: by mail-ob0-x233.google.com with SMTP id is5so23136715obc.0 for ; Wed, 27 Jan 2016 17:11:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=sender:subject:mime-version:content-type:from:in-reply-to:date:cc :message-id:references:to; bh=9mtKinJMG0A2rVgvQhlK+6Q0XzqZpCGGw6aZBVMo2v8=; b=yusXZOchdFdXqhmg4AmsFsDlaC1aVjAPxMHuhp5G+gYuiUPFKkDGvpo9tNPlRZSonN HpAjK9+V79sKuWjfAEBt0jGZsNah15xvr89vo4jMqKIa0AACGmXVdMjtRVjbZE4yU7M2 k614HhK1bxXWBE7sEPokE5HHivObj/WZpsrchTDkD88e6+rZaq5btlFOItE5WIcDlHDa E7hiLIJ3x/jtEsJBaORIbE960SfopL6fFw1AcmCda0z+Y/fZT6/ZAj2wU+VRPFowrohJ KjtRNVSE45nFsEX7UN7iNlWk6QSYqKiABU1JFQw6FOzs508eCvjdHecFmLPEILqaE8w4 gyLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:mime-version:content-type:from :in-reply-to:date:cc:message-id:references:to; bh=9mtKinJMG0A2rVgvQhlK+6Q0XzqZpCGGw6aZBVMo2v8=; b=N0aWEJ8Jg3q0kkushr96N1DZ4x5fWMaLnvRRewhGQknYOhLdTwx4hwukmeWv8oAoGY v7NjX4DxUCMZZQRY5wSUFDCcQ1rs0CeyYB8Lv7uE3ztfrmbpIS3AaUDZ5SMDgoct5vfH oz76DocicV9GmIbrxedToNewkXC97dG8aBvxNNZNJKudm3GY2S2p+jB8VvJeNciudRVB LdwrcV5LyXoy58tmaGC8VCjuASg/ZKS55wsDeDUy0235j4QkYq3xMf0ci9WbTeNiLH6p wvwy/mGDlWJFlT3D7s2qFE8fE5sZg0hE/rDgBXe2Qg6FK9ywg2ZsVfqpSnYwtR1juZQl s7tA== X-Gm-Message-State: AG10YOS6nZhArPTigRGEsf6m7Z+thL6Tkd/tSzRtuj0PG2wvgWZ+hM/pseBbBQNbrXv4TQ== X-Received: by 10.182.73.225 with SMTP id o1mr203256obv.80.1453943487125; Wed, 27 Jan 2016 17:11:27 -0800 (PST) Received: from ?IPv6:2601:280:4900:3700:314d:f855:ce09:86f9? ([2601:280:4900:3700:314d:f855:ce09:86f9]) by smtp.gmail.com with ESMTPSA id k204sm4232155oia.7.2016.01.27.17.11.26 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 27 Jan 2016 17:11:26 -0800 (PST) Sender: Warner Losh Subject: Re: SPI geom_flashmap/fdt_slicer support, FDT 'resets=' support and a move of ohci_fdt.c Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Content-Type: multipart/signed; boundary="Apple-Mail=_4967476C-6D18-4BF8-BB72-F56B9EAA26B5"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.5.2 From: Warner Losh In-Reply-To: <20160127192015.64d0ded0@stevek-ubuntu.jnpr.net> Date: Wed, 27 Jan 2016 18:11:24 -0700 Cc: Stanislav Galabov , freebsd-arm@freebsd.org, freebsd-mips@freebsd.org Message-Id: <55D21A1C-E1E3-4800-8069-8EA98A8F85A0@bsdimp.com> References: <20160122173906.147bb7c2@stevek-ubuntu.jnpr.net> <20160127192015.64d0ded0@stevek-ubuntu.jnpr.net> To: Steve Kiernan X-Mailer: Apple Mail (2.2104) X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Porting FreeBSD to ARM processors." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jan 2016 01:11:28 -0000 --Apple-Mail=_4967476C-6D18-4BF8-BB72-F56B9EAA26B5 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Jan 27, 2016, at 5:20 PM, Steve Kiernan wrote: >=20 > On Sat, 23 Jan 2016 07:18:04 +0200 > Stanislav Galabov wrote: >=20 >> It looks like only part of the original patch I submitted made it = into head >> (only the mx25l part). >> We also need to change sys/conf/files as Steve pointed out, as well = as >> sys/geom/geom_flashmap.c: >> https://bz-attachments.freebsd.org/attachment.cgi?id=3D165546 >=20 > One other thing that needs to be considered. The nand driver has an = ioctl > for getting chip parameters (see chip_param_io structure in > sys/dev/nand/nand_dev.h) and geom_flashmap only allows for > NAND_IO_GET_CHIP_PARAM to be passed to the provider. However, the CFI = and > SPI devices do not implement this and they probably should not as-is. > Something more generic to flash devices that are handled by = geom_flashmap > is probably in order. The different chip parameters shouldn=E2=80=99t be done through an ioctl = with geom. It should be done with geom attributes. We should implement a sensible = set for all three and have geom_flashmap use those instead of the ioctl. Warner --Apple-Mail=_4967476C-6D18-4BF8-BB72-F56B9EAA26B5 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJWqWq8AAoJEGwc0Sh9sBEAgokQAI5M65KgnMS90eGeIFoWcGSM RdwmoA79ic2anh3mzxI+18CQgV+NLX7A2dFPOCb+mXJcioTdirDns78LbQdsH4sr li659Ui84+bwuR0Ov8Qxi2ugyd2Z4iaFXITQ2G9l+lB1715ZLOEryVnMZaBbLyLl BnS/DuFuVh83CaDaYqQS0tA28dypaUk3uXb5I4RimUMVws824K+pePR6QeXShlHP z0Xf48rq3r2nBS4/jicQ8MLk6uA6kI/xjdMhbaMv3KxMPW2xdQfkvGCRjcXg41zA +Xi0XgUF+tL1LPmH0Gu4mZ/vG6oVWq3WrRT2a3r8l+qEnMJ5ezIbOMaNciaNOgbe 3M3gxBPsrp/ha1csTp9YmoRx7nzzKnmLkV3oAVlGrrf0lVNgsz8UJ+2v38LhMSeb q3wvenaEICtHYqCDgVXrEQu3AH9+qzD+D6LvqhOMJjJDfmf17fUs63wX5Eub4g4O OLodRn5ySWmXSCvZFPulC5Hi65CuUqJvL20pLSoQum0s/RGjWIh9B4/Ww933gOI1 Ab4L1MasQ5DHkeC4wsR60M44BnBR0slooAQJnTn2MT/JkSWLgdFT5dLYHKiwSaq8 KTjoDDMAlznh+XQQBmc/l8AElkVNEXcX+g/fqcz2l6mzxY/1VdTrCBpmSsVRJK7y +UcEDqHid5YWeBVcRQwd =Gb2T -----END PGP SIGNATURE----- --Apple-Mail=_4967476C-6D18-4BF8-BB72-F56B9EAA26B5--