From nobody Sat Mar 21 21:40:23 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fdXsn2Lz8z6W4vV; Sat, 21 Mar 2026 21:40:29 +0000 (UTC) (envelope-from freebsd@walstatt-de.de) Received: from smtp052.goneo.de (smtp052.goneo.de [85.220.129.60]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4fdXsm5VBxz3LkC; Sat, 21 Mar 2026 21:40:28 +0000 (UTC) (envelope-from freebsd@walstatt-de.de) Authentication-Results: mx1.freebsd.org; none Received: from hub1.goneo.de (hub1.goneo.de [IPv6:2001:1640:5::8:52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by smtp5.goneo.de (Postfix) with ESMTPS id 11510240870; Sat, 21 Mar 2026 22:40:27 +0100 (CET) Received: from hub1.goneo.de (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by hub1.goneo.de (Postfix) with ESMTPS id 293FA24012F; Sat, 21 Mar 2026 22:40:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walstatt-de.de; s=DKIM001; t=1774129225; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GVvhhkr7grBshlPLnMj9UpAadtFxBFPZX9NrGdkT8MU=; b=kWZWRQNIO1rRUb1OpVzeMuonmx/O0/n8Zl5U5gG4p93BAWjsrc3VJc/qPW9RvpZ0sN2LqU TXL7D/KCJzNaTlddOjwVggpItfyVpnN40IyDjB/zbP+kVEwajca/ozadlRiR1ghyKemZWP lXPbghNTnK8/bS1UjRsrING+evDSCAgGLI160gWzHvpulgFnVmr1L1MwnVdPe5Ehh9JKV0 LnR2ke0A0j/MSBCx6MLyJJ2caGA5TMZrCZyZsUpgedLwUTCB9lvf+M72z4Dq3YcGEo+fs9 waQlrhMWwY7yVnbp+DwNhG9lVpFssWiwy9+Sj3TksXOLQqwOgJrBroRb4I15/Q== Received: from hermann (dynamic-2a02-3100-1987-1e02-8578-13fe-ee89-5215.310.pool.telefonica.de [IPv6:2a02:3100:1987:1e02:8578:13fe:ee89:5215]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by hub1.goneo.de (Postfix) with ESMTPSA id C1F8B240023; Sat, 21 Mar 2026 22:40:24 +0100 (CET) Date: Sat, 21 Mar 2026 22:40:23 +0100 From: FreeBSD User To: Konstantin Belousov Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 8cc1c0f35ec8 - main - amd64 trap.c: provide tag for the struct sfhandlers definition Message-ID: <20260321224023.002fcb9b@hermann> In-Reply-To: References: <69bdcf15.27526.2b5005f0@gitrepo.freebsd.org> <20260321171438.680a77e3@hermann> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-UID: 01c240 X-Rspamd-UID: f4e032 X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:25394, ipnet:85.220.128.0/17, country:DE] X-Rspamd-Queue-Id: 4fdXsm5VBxz3LkC X-Spamd-Bar: ---- On Sat, 21 Mar 2026 20:57:13 +0200 Konstantin Belousov wrote: > On Sat, Mar 21, 2026 at 05:15:55PM +0100, FreeBSD User wrote: > > On Fri, 20 Mar 2026 22:49:57 +0000 > > Konstantin Belousov wrote: > > > > > The branch main has been updated by kib: > > > > > > URL: > > > https://cgit.FreeBSD.org/src/commit/?id=8cc1c0f35ec8d5a3edb4ee1ede962a3c1f6baef0 > > > > > > commit 8cc1c0f35ec8d5a3edb4ee1ede962a3c1f6baef0 > > > Author: Konstantin Belousov > > > AuthorDate: 2026-03-03 06:37:03 +0000 > > > Commit: Konstantin Belousov > > > CommitDate: 2026-03-20 22:49:03 +0000 > > > > > > amd64 trap.c: provide tag for the struct sfhandlers definition > > > > > > Sponsored by: The FreeBSD Foundation > > > MFC after: 1 week > > > --- > > > sys/amd64/amd64/trap.c | 6 ++++-- > > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > > > diff --git a/sys/amd64/amd64/trap.c b/sys/amd64/amd64/trap.c > > > index 8a1d1528e6da..359b3dfe3609 100644 > > > --- a/sys/amd64/amd64/trap.c > > > +++ b/sys/amd64/amd64/trap.c > > > @@ -319,10 +319,12 @@ trap_check_intr_kernel(struct thread *td, struct > > > trapframe *frame) /* > > > * Table of handlers for various segment load faults. > > > */ > > > -static const struct { > > > +struct sfhandler { > > > uintptr_t faddr; > > > uintptr_t fhandler; > > > -} sfhandlers[] = { > > > +}; > > > + > > > +static const struct sfhandler sfhandlers[] = { > > > { > > > .faddr = (uintptr_t)ld_ds, > > > .fhandler = (uintptr_t)ds_load_fault, > > > > > > > Hello, > > > > it seems that one of the commits in this vain results in a hard reset of > > some CURRENT machine - this taken from some reports on freebsd-current list. > > > > In my case, two Zen5 based boxes, bott as usual, but when touch the system > > with "make buildworld buildkernel" or any single make build on the acting > > server box, the system reboots immediately - no trace of a log, coredump, > > simple nothing. Only hard reset. Same on another box acting as graphical > > workstation. As soon the system gets "touch" (login/starting windowmaker) > > the system goes nirwana. > > > > No further information, my boxes do not dump anything useful. > > Try the following > > commit 237044fd4d0659ef2799c259b1f1852c00b08b37 > Author: Konstantin Belousov > Date: Sat Mar 21 20:45:48 2026 +0200 > > amd64: use IDT trapframe size to calculate location of nmi_pcpu from the > IST stack pointer > > diff --git a/sys/amd64/amd64/exception.S b/sys/amd64/amd64/exception.S > index babfbacf92ef..5bf9a12e1bf5 100644 > --- a/sys/amd64/amd64/exception.S > +++ b/sys/amd64/amd64/exception.S > @@ -341,7 +341,7 @@ IDTVEC(dblfault) > pushfq > andq $~(PSL_D | PSL_AC),(%rsp) > popfq > - movq TF_SIZE(%rsp),%rdx > + movq TF_SIZE_HW(%rsp),%rdx > movl %edx,%eax > shrq $32,%rdx > movl $MSR_GSBASE,%ecx > @@ -661,7 +661,7 @@ IDTVEC(dbg) > shlq $32,%rdx > orq %rdx,%r12 > /* Retrieve and load the canonical value for GS.base. */ > - movq TF_SIZE(%rsp),%rdx > + movq TF_SIZE_HW(%rsp),%rdx > movl %edx,%eax > shrq $32,%rdx > wrmsr > @@ -798,7 +798,7 @@ IDTVEC(nmi) > shlq $32,%rdx > orq %rdx,%r12 > /* Retrieve and load the canonical value for GS.base. */ > - movq TF_SIZE(%rsp),%rdx > + movq TF_SIZE_HW(%rsp),%rdx > movl %edx,%eax > shrq $32,%rdx > wrmsr > @@ -1002,7 +1002,7 @@ IDTVEC(mchk) > shlq $32,%rdx > orq %rdx,%r12 > /* Retrieve and load the canonical value for GS.base. */ > - movq TF_SIZE(%rsp),%rdx > + movq TF_SIZE_HW(%rsp),%rdx > movl %edx,%eax > shrq $32,%rdx > wrmsr > diff --git a/sys/amd64/amd64/genassym.c b/sys/amd64/amd64/genassym.c > index 2716784ee871..762c850c1df1 100644 > --- a/sys/amd64/amd64/genassym.c > +++ b/sys/amd64/amd64/genassym.c > @@ -185,6 +185,7 @@ ASSYM(TF_FS, offsetof(struct trapframe, tf_fs)); > ASSYM(TF_GS, offsetof(struct trapframe, tf_gs)); > ASSYM(TF_FLAGS, offsetof(struct trapframe, tf_flags)); > ASSYM(TF_SIZE, sizeof(struct trapframe)); > +ASSYM(TF_SIZE_HW, sizeof(struct trapframe) - 2 * 8); > ASSYM(TF_HASSEGS, TF_HASSEGS); > > ASSYM(PTI_RDX, offsetof(struct pti_frame, pti_rdx)); > Just gave the patch of yours a chance before sleeping time on the GUI box of mine: after reboot, starting GUI (windowmaker) a total freeze of the system immediately. I'll check on the other machine without burden of GUI tomorrow morning. Still it seems the box isn't dumping/reporting anything, this time just frozen. Kind regards, Oliver