From owner-svn-src-head@FreeBSD.ORG  Tue May  6 15:44:11 2014
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 65761870;
 Tue,  6 May 2014 15:44:11 +0000 (UTC)
Received: from mail.turbocat.net (mail.turbocat.net
 [IPv6:2a01:4f8:d16:4514::2])
 (using TLSv1.1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 2781C7F;
 Tue,  6 May 2014 15:44:10 +0000 (UTC)
Received: from laptop015.home.selasky.org
 (cm-176.74.213.204.customer.telag.net [176.74.213.204])
 (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits))
 (No client certificate requested)
 by mail.turbocat.net (Postfix) with ESMTPSA id 9718C1FE029;
 Tue,  6 May 2014 17:44:09 +0200 (CEST)
Message-ID: <53690381.9040909@selasky.org>
Date: Tue, 06 May 2014 17:45:05 +0200
From: Hans Petter Selasky <hps@selasky.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:24.0) Gecko/20100101 Thunderbird/24.1.0
MIME-Version: 1.0
To: Warner Losh <imp@bsdimp.com>
Subject: Re: svn commit: r265359 - head/sys/modules/sound/sound
References: <201405051431.s45EVZ2q027729@svn.freebsd.org>
 <7745BD19-5BAE-47BD-8DE4-10CF7E23FA9D@gmail.com>
In-Reply-To: <7745BD19-5BAE-47BD-8DE4-10CF7E23FA9D@gmail.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 8bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers <src-committers@freebsd.org>
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 06 May 2014 15:44:11 -0000

On 05/05/14 22:39, Warner Losh wrote:
>
> On May 5, 2014, at 8:31 AM, Hans Petter Selasky <hselasky@freebsd.org> wrote:
>
>> Author: hselasky
>> Date: Mon May  5 14:31:34 2014
>> New Revision: 265359
>> URL: http://svnweb.freebsd.org/changeset/base/265359
>>
>> Log:
>>   Build the kernel sound module without ISA DMA support for ARM and MIPS
>>   platforms, because these platforms do not implement the ISA DMA
>>   API. Else the sound modules cannot be loaded when running these
>>   platforms.
>>
>>   MFC after:	2 weeks
>>
>> Modified:
>>   head/sys/modules/sound/sound/Makefile
>>
>> Modified: head/sys/modules/sound/sound/Makefile
>> ==============================================================================
>> --- head/sys/modules/sound/sound/Makefile	Mon May  5 11:50:52 2014	(r265358)
>> +++ head/sys/modules/sound/sound/Makefile	Mon May  5 14:31:34 2014	(r265359)
>> @@ -44,7 +44,8 @@ CLEANFILES+=	feeder_eq_gen.h feeder_rate
>>
>> EXPORT_SYMS=	YES	# XXX evaluate
>>
>> -.if ${MACHINE_CPUARCH} == "sparc64" || ${MACHINE_CPUARCH} == "powerpc"
>> +.if ${MACHINE_CPUARCH} == "sparc64" || ${MACHINE_CPUARCH} == "powerpc" || \
>> +    ${MACHINE_CPUARCH} == "arm" || ${MACHINE_CPUARCH} == "mips"
>> # Create an empty opt_isa.h in order to keep kmod.mk from linking in an
>> # existing one from KERNBUILDDIR which possibly has DEV_ISA defined so
>> # sound.ko is always built without isadma support.
>
> Rather than an opt-in approach here, why not lust list the three that have it since
> they are the only ones that will ever have it…
>
> Warner
>

Hi,

Maybe the sound DMA file belongs in its own module?

--HPS