From owner-freebsd-hackers@freebsd.org  Wed May 24 09:25:37 2017
Return-Path: <owner-freebsd-hackers@freebsd.org>
Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 45F6AD7BF16
 for <freebsd-hackers@mailman.ysv.freebsd.org>;
 Wed, 24 May 2017 09:25:37 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id D115F1123
 for <freebsd-hackers@freebsd.org>; Wed, 24 May 2017 09:25:36 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from tom.home (kib@localhost [127.0.0.1])
 by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id v4O9PUsD034260
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Wed, 24 May 2017 12:25:31 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua v4O9PUsD034260
Received: (from kostik@localhost)
 by tom.home (8.15.2/8.15.2/Submit) id v4O9PUsP034256;
 Wed, 24 May 2017 12:25:30 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com
 using -f
Date: Wed, 24 May 2017 12:25:30 +0300
From: Konstantin Belousov <kostikbel@gmail.com>
To: Sebastian Huber <sebastian.huber@embedded-brains.de>
Cc: freebsd-hackers@freebsd.org
Subject: Re: [PATCH] Use __BSD_VISIBLE for Termios headers
Message-ID: <20170524092530.GH1622@kib.kiev.ua>
References: <20170524060758.25529-1-sebastian.huber@embedded-brains.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170524060758.25529-1-sebastian.huber@embedded-brains.de>
User-Agent: Mutt/1.8.2 (2017-04-18)
X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no
 autolearn_force=no version=3.4.1
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
 <freebsd-hackers.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers/>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 24 May 2017 09:25:37 -0000

On Wed, May 24, 2017 at 08:07:58AM +0200, Sebastian Huber wrote:
> The Termios headers <termios.h> and <sys/_termios.h> used sometimes
> _POSIX_SOURCE directly to determine if a thing should be exposed to the
> user.
> 
> This circumvented the feature mechanisms of <sys/cdefs.h>.  Use
> __BSD_VISIBLE instead.
> ---
>  include/termios.h  |  8 ++++----
>  sys/sys/_termios.h | 44 ++++++++++++++++++++++----------------------
>  2 files changed, 26 insertions(+), 26 deletions(-)

Committed as r318780, thank you.