From nobody Mon Feb 28 19:04:28 2022 X-Original-To: freebsd-stable@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id C1C9419FCE4A for ; Mon, 28 Feb 2022 19:04:39 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic314-20.consmr.mail.gq1.yahoo.com (sonic314-20.consmr.mail.gq1.yahoo.com [98.137.69.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4K6qYy4hVcz4SV0 for ; Mon, 28 Feb 2022 19:04:38 +0000 (UTC) (envelope-from marklmi@yahoo.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1646075070; bh=FoK5iMw7XqjVUCusJwRhHjOqebE2ImUt6qVe6wvUWf8=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From:Subject:Reply-To; b=aZtlmugjdvpmjaMz2oLekv/CMSYXLEQJTkrFptLrdQ1zRaqDklCX73Uc96hj0a8ZTbDCR/CoUoSNNvwD3Ax0DtTpdYtd9t1CkdHkycZQHvOWpwaAVdbw4ERYMoMkOGR9gyyiRhzLeefwk1APzdTLqB7HigVRhCKr+C/6eNhaGrxAylPb4vJMtMfmyqgJv+qR7riqJq8p67KF4vsP5mLtAJ6jhyBoQepkFv9u4qkhdtwW9w6WBZLxv5tn7/QHsYUhsU+ny1u139t1yMqzoCv4EjdFIrHQLMZG1JMz5UWM9yGPw+mjGe/diT4cMmUyrPigUbOFYM2L8Ak0AcjWHXJjmA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1646075070; bh=a6wvs2fYb2sIjeSDdKV3VzkfH5hG0dDRzGZKh6uyOlP=; h=X-Sonic-MF:Subject:From:Date:To:From:Subject; b=JhsCKHckHWyOu2Pnj8/LAqjl05NlDSK+txelr04ulNGQuzuHd4+KBWIWB5JoiAszabqvBAwgBCDEFX0et7oLu28ChnySB4IUp23LE4KtlxmhnkhBtTbcKmm8ekygeIUXidTrr+riHtrtj3m3Q1ZzmRgFppRFr6GRVfxjOs1PhxX0W7SxKX4f1DIe7pZa+Y73GQRkDNY/lYDw/yc2/uvE2rOYeBi8EaO0aNZJp7x+mm/yAXw8KWMYC/BGR9xgSsjTmVyBagCAhG1/ObT3ixfe9GAOjPbHavAtDsK5RV641wcbhyKjEYP5P0oHsvgSyH1jYXOo5wrdlDDvD4uKTtPZwQ== X-YMail-OSG: kHqwLNcVM1kdnmI3TZY87q30bmQJhYZHpYAjgQT0Q.AQ4ZgwbRBTDzL7mmittST U38f5sw.oVATbzPlT47QwHVPuhf4Q9.UhGvEQBqXVFV9RFnnyzbrXlh44p2Qfb_kGFb2cmE98NZ5 Q_uwA9Ducc1uw0J0x_xtD..B3dLgCzjL4q32dxC.Euh9BP_phHSKC3VV8Tz70aWyXdrFDgQeqJNd w7mSxi_ZHlZieU3CqWxfAdEvUT67JEH8eBRVo4.5LuuQoBiYu8TdHb62Wwe1lyXWec0H4flzXWr6 FkJeI7Bav1Z0Yx1Ax7faA9GyvEN0X5oAwQFNC88ZDpJaVEWmT.paxwYj4ZFeLY8VYIndGhL60BGX uguqrIC5YdLrojDv1lNG0EsC3OBXIPDpXui8fVDM8fIO.ABsU7eSxAThfpsQ3aADVRZny0Jl4_Gy gUvD6aEWK9hM_tFzYjGcJPDHIy.NIrVeyONmAzUZvddqAQzMJ4JlyVDssKhbWLJYs6dpHzT820pm 5wkoD7zh_og_BASGToSGYk6xk2c90KO58ucZ_tofbCUaomOtX6qp70CB_RJUUfyT6nGH2Jgy_VKs ShFc8cUQ7eXnoJXdKvaj1X5.mSkDZ3W3wk1K01mZOa2N_2HDbrTkn8cI5KIwg2P.dn9yTDNkNa2X VeGw_bg4TqiiO8qLXruBuEubBnmC8inXofzeb427WWzIIvSeVTZ1OAE1ElxUYqUHaxb_PkJtmImM 34223kvEOHRkDoIAOE9yt.tnySXdOVHrGylVfBcMne2sbFHFYaLUOGrxHgDIEeIYAyfKNKBkZbFp FOPbG3vJE9RnPhhOAKPV1HeZIZ52EEX.GqS.g6lyD7.neOz4GqI8T4uHFzQI84PZMXtK85gYoaRR xXN7_CDXM81O90lQgzGKeZ_l_IOSsLB7wMwedVJ9N46PjhMq.89Llq2BU5uCmCV1H4ChxDQEp.MI Pr.ioUPqeF123t3X3rbZCNXXmmXVzb9xTwrZqxhPG8UCVfeiB6lfNoqVtQXF3kHZgIx7ue4eGTFc VrOXcr1oVtzuoueqNDOHhS7lEYs7Mnez76rdir8f2vZk3xBhjXzb1flYj3rmOCuHP2eTZUfAlhFk ZSzn0xt0JQaK8lFvoJvY__cMm6clnWF2JDo0ZCMVby_7yA9_AQI7bY7RkU0jg27LTowvypcuA.7S EFip1GW2QQ6VHGh132BnX17SdwdmVqLl0YE_m7.SsEi4Sr7tNFbQzD4jYhJObE6rpJ9f5Ap.NsnS .2W6iPCNJ6rWUnR.LHZVlp_SGPXLB9l1lAcM2wiLO1XIFpv6IjXrC0BPo8Yv2jwCfhR.9euBOQ8x RGGXLGclIH5dR1iMoP_qdNZUlZrudBMdO5e.rtHABxIbBvzyAkdN9JC.l_6Nsy1c0WLfXnS9PKBR SezLpHZgALNqeEpyONtdjjbhey.nMmgtHLjyP6hvamIShaSIa9n86M1NKqd2Le3n0xrpp51qP_tH r_mzDmyRf6iz26KyvUkuAWSyVR8r4R9eqM8MIb21ZcKqNIReRQIPgG4GYion2kIcmakiHAFgTsy6 ie5V1ic6FLZ112sm.A8HUO6dk5_BwtHDqdP1PyIy1yOS9S3i9aYTVa1P7RcsnTzDCGkpU33n.ZyT QqfJrRIPGRmmcwl854vP4sovLINO_f9qrLtLqzfyp25jZoX0yiUpdFNPPcap88O2Q5R8x.aWj46z LfqKSkwVj7BZOTo2sMGVztPljpeFKfIX00a_5sPHr2wIm68AIiOHftLFbTC.2INj5JE4nuO7Jl6h 9FLnJQtuhucN00_FgEtVs1W0KqSPHIlmpT3jRQMuQbBwtCKfwi_tybGZrBQUfC0IwUFPPv9oN.Y0 F_bBzKrl9Tvl2P4C8rc1RQ9kpbupw6zwZT2RvuIPejwu7iwdiQua_RKL2Diceplpui01joQpYwow DzwyqkGwvKymZnQCYWHGuvp1c1LC2Rue5LOnCE5Q_z0niv6SKht2KTvZabyz7DYvnFxyL8_GktOU hXo.mscgNICEkkGfIEgiCfVRhLdBCVa_kDjBmX4BBZ1vbNyiFVakTtc8ORAt_Zn7p9PB69S6Vl9r k4uXJBLWp57A4VUbNnPNLTW6CGprgiewoyNlLXC0OTqNSjKNJari_bxnLBhT3jftGHb81YoqQMjn e9fG3czHswW_rp3k50LH_h1mXr40NfP4NSxMthiTxTGAaAvuGFrh9DwPv2S_fUkrOKxCRj8wQuUa gpVvXpm_Q8lJRCrIePdxKgVHrrULUErGY0KwtHRS8_6kKJ1fgbmYw.JqMVpAOsjZSciv7wHtPl3C l71HEjhrZrvjLJn2FGghZDg-- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.gq1.yahoo.com with HTTP; Mon, 28 Feb 2022 19:04:30 +0000 Received: by kubenode512.mail-prod1.omega.gq1.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 93b09ef7edd5ea69ef32b18fa25b3b85; Mon, 28 Feb 2022 19:04:29 +0000 (UTC) Content-Type: text/plain; charset=us-ascii List-Id: Production branch of FreeBSD source code List-Archive: https://lists.freebsd.org/archives/freebsd-stable List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-stable@freebsd.org X-BeenThere: freebsd-stable@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: Re: git: 4a864f624a70 - main - vm_pageout: Print a more accurate message to the console before an OOM kill [MFC in time for 13.1?] From: Mark Millard In-Reply-To: Date: Mon, 28 Feb 2022 11:04:28 -0800 Cc: freebsd-current , dev-commits-src-main@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <49BCAD72-1D83-4D85-912F-DF6FD92BB440@yahoo.com> References: <1EF55D96-F7E3-4AA6-A331-782362A70878.ref@yahoo.com> <1EF55D96-F7E3-4AA6-A331-782362A70878@yahoo.com> To: Mark Johnston , FreeBSD-STABLE Mailing List X-Mailer: Apple Mail (2.3654.120.0.1.13) X-Rspamd-Queue-Id: 4K6qYy4hVcz4SV0 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=yahoo.com header.s=s2048 header.b=aZtlmugj; dmarc=pass (policy=reject) header.from=yahoo.com; spf=pass (mx1.freebsd.org: domain of marklmi@yahoo.com designates 98.137.69.83 as permitted sender) smtp.mailfrom=marklmi@yahoo.com X-Spamd-Result: default: False [-3.50 / 15.00]; TO_DN_SOME(0.00)[]; FREEMAIL_FROM(0.00)[yahoo.com]; MV_CASE(0.50)[]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; DKIM_TRACE(0.00)[yahoo.com:+]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US]; MID_RHS_MATCH_FROM(0.00)[]; SUBJECT_HAS_QUESTION(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DWL_DNSWL_NONE(0.00)[yahoo.com:dkim]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[98.137.69.83:from]; MLMMJ_DEST(0.00)[freebsd-stable]; RWL_MAILSPIKE_POSSIBLE(0.00)[98.137.69.83:from]; RCVD_COUNT_TWO(0.00)[2] X-ThisMailContainsUnwantedMimeParts: N On 2022-Feb-26, at 17:10, Mark Millard wrote: > On 2022-Jan-15, at 07:55, Mark Johnston wrote: >=20 >> On Fri, Jan 14, 2022 at 09:38:56PM -0800, Mark Millard wrote: >>> Thanks. This will allow me to remove part of my personal additions >>> in this area --and my having to explain the misnomer when trying >>> to help someone analyze why they end up with OOM activity so they >>> can figure out what to do about it. >>>=20 >>> There seem to be two separate sources of VM_OOM_SWAPZ. Showing >>> my personal additions for them (just making them explicit in the >>> sequence of messages generated): >>>=20 >>> diff --git a/sys/vm/swap_pager.c b/sys/vm/swap_pager.c >>> index 01cf9233329f..280621ca51be 100644 >>> --- a/sys/vm/swap_pager.c >>> +++ b/sys/vm/swap_pager.c >>> @@ -2091,6 +2091,7 @@ swp_pager_meta_build(vm_object_t object, = vm_pindex_t pindex, daddr_t swapblk) >>> 0, 1)) >>> printf("swap blk zone = exhausted, " >>> "increase = kern.maxswzone\n"); >>> + printf("swp_pager_meta_build: swap = blk uma zone exhausted\n"); >>> vm_pageout_oom(VM_OOM_SWAPZ); >>> pause("swzonxb", 10); >>> } else >>> @@ -2121,6 +2122,7 @@ swp_pager_meta_build(vm_object_t object, = vm_pindex_t pindex, daddr_t swapblk) >>> 0, 1)) >>> printf("swap pctrie zone = exhausted, " >>> "increase = kern.maxswzone\n"); >>> + printf("swp_pager_meta_build: swap = pctrie uma zone exhausted\n"); >>> vm_pageout_oom(VM_OOM_SWAPZ); >>> pause("swzonxp", 10); >>> } else >>>=20 >>> Care to comment on the distinctions and why there are two >>> contexts classified as "out of swap space"? Would either >>> one show the swap space as (nearly?) all used in, say, top? >>> Or might one of them still end up looking like a misnomer >>> from just a top (or whatever) display? >>=20 >> Hmm, those cases should likely be changed from "out of swap space" to >> "failed to allocate swap metadata" or something like that. >=20 > The above does not seem to have happened yet in main [so: 14]. >=20 > Will 13.1 get an MFC of 4a864f624a70 in time, possibly with the > above change also in place to fully avoid misnomer reporting > that misleads folks? >=20 > 4a864f624a70 listed: >=20 > MFC after: 2 weeks >=20 > but it has been more than a month. >=20 >> . . . >>=20 >=20 Thanks for the stable/13 MFC as 13ba1d283676. It provides a big improvement over the prior messaging for the OOM kills. For reference, I do still view: + case VM_OOM_SWAPZ: + reason =3D "out of swap space"; + break; as using a confusing misnomer ("swap space") for its message. But, so far as I know, VM_OOM_SWAPZ is a rarity and possibly very difficult to produce. If so, any confusions from the message should also be rare. =3D=3D=3D Mark Millard marklmi at yahoo.com