Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 21 Jan 2015 17:21:26 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 196843] [maintainer update] www/glpi 0.85.1
Message-ID:  <bug-196843-13-pjsrd6eEyB@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-196843-13@https.bugs.freebsd.org/bugzilla/>
References:  <bug-196843-13@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196843

--- Comment #8 from John Marino <marino@FreeBSD.org> ---
Great!
I only see one issue.

Please change "cd ${WRKSRC} && ${COPYTREE_SHARE} . ${STAGEDIR}${WWWDIR}"
to "(cd ${WRKSRC} && ${COPYTREE_SHARE} . ${STAGEDIR}${WWWDIR})"

Compound commands require the parenthesis in order to properly support multijob
building.

In this case, it's probably not really needed but lets set a good example or
CYA in case I'm wrong about that.  It definitely is not wrong to add the
parentheses. :)

When you update the new version, I'll promote the PR.

-- 
You are receiving this mail because:
You are the assignee for the bug.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-196843-13-pjsrd6eEyB>