From owner-cvs-src@FreeBSD.ORG  Thu Nov 13 12:24:05 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 723DE16A4CE; Thu, 13 Nov 2003 12:24:05 -0800 (PST)
Received: from beastie.mckusick.com (beastie.mckusick.com [209.31.233.184])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 8A65343F3F; Thu, 13 Nov 2003 12:24:04 -0800 (PST)
	(envelope-from mckusick@beastie.mckusick.com)
Received: from beastie.mckusick.com (localhost [127.0.0.1])
	by beastie.mckusick.com (8.12.8/8.12.3) with ESMTP id hADKO3aG009382;
	Thu, 13 Nov 2003 12:24:03 -0800 (PST)
	(envelope-from mckusick@beastie.mckusick.com)
Message-Id: <200311132024.hADKO3aG009382@beastie.mckusick.com>
To: Robert Watson <rwatson@FreeBSD.org>
In-Reply-To: Your message of "Wed, 12 Nov 2003 19:03:07 EST."
             <Pine.NEB.3.96L.1031112190222.96006B-100000@fledge.watson.org> 
Date: Thu, 13 Nov 2003 12:24:03 -0800
From: Kirk McKusick <mckusick@beastie.mckusick.com>
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern kern_timeout.c 
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Nov 2003 20:24:05 -0000

> Date: Wed, 12 Nov 2003 19:03:07 -0500 (EST)
> From: Robert Watson <rwatson@FreeBSD.org>
> X-Sender: robert@fledge.watson.org
> To: Kirk McKusick <mckusick@FreeBSD.org>
> Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
> Subject: Re: cvs commit: src/sys/kern kern_timeout.c
> In-Reply-To: <200311122228.hACMSSwZ027025@repoman.freebsd.org>
> 
> On Wed, 12 Nov 2003, Kirk McKusick wrote:
> 
> > mckusick    2003/11/12 14:28:28 PST
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     sys/kern             kern_timeout.c 
> >   Log:
> >   At the request of several developers, restore the DIAGNOSIC code
> >   deleted in 1.81. Increase the initial timeout limit to 2ms to
> >   eliminate spurious messages of excessive timeouts in the NFS
> >   client code.
> >   
> >   Requested by:   Poul-Henning Kamp <phk@phk.freebsd.dk>
> >   Requested by:   Mike Silbersack <silby@silby.com>
> >   Requested by:   Sam Leffler <sam@errno.com>
> 
> Could this have been responsible for the apparent hangs some (few but
> unfortunate) users were seeing with NFS, frequently accompanied by notices
> that the NFS server was unreachable? 
> 
> Robert N M Watson             FreeBSD Core Team, TrustedBSD Projects
> robert@fledge.watson.org      Network Associates Laboratories

The above code is only included when DIAGNOSTIC is defined and
is purely diagnostic (printing out a warning when an event called
from the timeout queue takes longer than the threshhold: formerly
1ms now 2ms). So, at best it might have provided a warning. It
certainly could not have caused/fixed the problem.

	Kirk McKusick