From owner-svn-src-all@freebsd.org Wed Jan 24 17:40:02 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A8907EB78FC; Wed, 24 Jan 2018 17:40:02 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-it0-f51.google.com (mail-it0-f51.google.com [209.85.214.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 40A9E6B789; Wed, 24 Jan 2018 17:40:02 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-it0-f51.google.com with SMTP id u62so6089469ita.2; Wed, 24 Jan 2018 09:40:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc:content-transfer-encoding; bh=acRulSFKh8NOcPHFrPFrDrO3aSx8UMnavzLCSEBpK2A=; b=V5UZlaNJNS0Lzg8PBlGRVCgCggOmnmgJ63onjO9KndxPOZUm42icdWxQCHwS1Gzh49 eneHZoCBY06qMwWKOSQPEIH+hTmF+aXJIZe4UJ6PMB1eU/zWRdirEArBQ9+yk5ZkX369 J9Zqnoeevw6lYltwG9VoObR82pB4t89AwzGCR2I2e7EfafFuoTQqs4C4PRT/nArqPQm8 zIokRSHabo1BIgBbBamqpHbpjgNuianhigyzGgF9XWWfYaUA4bztQu+z1cbcFSqd0PS3 qxBfUOQ8+8lbkNXFnUJUQsnXxTVTbVXqjAg0G1QkMMi0qYNo3k6PTp71oG5l62rdWy5k EABQ== X-Gm-Message-State: AKwxytf84Qubvh1JfhoYDriNa+73VeBgQH3SAFQPN/xc6pg1PgzRLIEO WXunLe1v+8JfeQ473tuhWqLGc1CU X-Google-Smtp-Source: AH8x225mxmJXoNQnpLSFiMFpBNQWWkc8LHrwJ1XxWhQ6u74tetzrlUbd1lPYFZsZlhj8Yaw5F9NHGg== X-Received: by 10.36.87.83 with SMTP id u80mr9919546ita.140.1516815269972; Wed, 24 Jan 2018 09:34:29 -0800 (PST) Received: from mail-it0-f47.google.com (mail-it0-f47.google.com. [209.85.214.47]) by smtp.gmail.com with ESMTPSA id 64sm438506iox.0.2018.01.24.09.34.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Jan 2018 09:34:29 -0800 (PST) Received: by mail-it0-f47.google.com with SMTP id b77so6068861itd.0; Wed, 24 Jan 2018 09:34:29 -0800 (PST) X-Received: by 10.36.84.205 with SMTP id t196mr9853050ita.128.1516815269236; Wed, 24 Jan 2018 09:34:29 -0800 (PST) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 10.2.95.152 with HTTP; Wed, 24 Jan 2018 09:34:28 -0800 (PST) In-Reply-To: References: <201801211542.w0LFgbsp005980@repo.freebsd.org> <51ff8aef-5660-7857-e4d5-12cdc77bc071@FreeBSD.org> <20180124182548.X1063@besplex.bde.org> From: Conrad Meyer Date: Wed, 24 Jan 2018 09:34:28 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r328218 - in head/sys: amd64/amd64 arm/xscale/ixp425 arm64/arm64 cam cam/ctl compat/ndis dev/aacraid dev/advansys dev/ath dev/beri/virtio dev/bnxt dev/bwn dev/ciss dev/cxgbe/crypto dev/... To: Warner Losh Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jan 2018 17:40:02 -0000 On Wed, Jan 24, 2018 at 7:44 AM, Warner Losh wrote: > I agree completely. It doesn't do what you think it is doing, for all the > reasons that Bruce outlines. We thought it was a bad idea when it came up= 2 > years ago and nothing has really changed. I disagree. I'm not sure what you mean by "it doesn't do what you think it is doing." Do you think the manual page is unclear or needs more detail? It seems clear to me, but it also does what I think it does. Your description of two years ago is inaccurate =E2=80=94 you thought it wa= s a bad idea, and were the most vocal on the mailing list about it, but that viewpoint was not universally shared. In a pure headcount vote I think you were even outvoted, but as the initiative was headed by a non-committer, it sputtered out. If Bruce has made some important point or illumination, please highlight it. It's buried in the mostly nonsense wall of text boilerplate he usually includes. mallocarray serves an important function =E2=80=94 a last ditch seatbelt against overflowing allocations that can trivially replace existing naive malloc calls containing multiplication. Trivial heap corruption is replaced with DoS =E2=80=94 a strict improvement. That is all it does. Best, Conrad