From owner-freebsd-hackers@FreeBSD.ORG  Mon Jul 12 07:44:49 2010
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6A504106566B
	for <hackers@freebsd.org>; Mon, 12 Jul 2010 07:44:49 +0000 (UTC)
	(envelope-from yanegomi@gmail.com)
Received: from mail-iw0-f182.google.com (mail-iw0-f182.google.com
	[209.85.214.182])
	by mx1.freebsd.org (Postfix) with ESMTP id 36E318FC15
	for <hackers@freebsd.org>; Mon, 12 Jul 2010 07:44:49 +0000 (UTC)
Received: by iwn35 with SMTP id 35so5442346iwn.13
	for <hackers@freebsd.org>; Mon, 12 Jul 2010 00:44:48 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:mime-version:received:received:date:message-id
	:subject:from:to:content-type;
	bh=3CciWMAQo7QvH/JSxL5Ee5wAkUpSf/AbQtAgyVfxnuM=;
	b=wVkS8KN30imsmaUKCI+c8GCpyksdV/kAgVgjuXak2QHPKhLkL0Xsh1ZkyTsFHEkcw3
	Wn34HrNBqlzgDNhGoJfs2wvs3Fd4+UkNd7BPAhAnIhw1umpZl9aJUd2ldkp8LRd5x09a
	/sIz/8QSDghsI3Sc3NwjstiV4F+FYjgatPR+E=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=mime-version:date:message-id:subject:from:to:content-type;
	b=HIsqHdd/a4EkOT3eM8VrPhQqE6axMDDKYxjHBr/gNfXjDxQtylhZEh8HADy3I2Fdwn
	y9AIsT5uAcTKG5/hdFybhW0Y+lFT3k03dUPJlsVV+Rfhbc6qdr7MaOtFHKgKTDtr0eeC
	JwaRafBEbfqYnXZWOchK9DBYH5cyuLr6Ma6sQ=
MIME-Version: 1.0
Received: by 10.231.169.131 with SMTP id z3mr14577766iby.48.1278920688676; 
	Mon, 12 Jul 2010 00:44:48 -0700 (PDT)
Received: by 10.231.182.74 with HTTP; Mon, 12 Jul 2010 00:44:48 -0700 (PDT)
Date: Mon, 12 Jul 2010 00:44:48 -0700
Message-ID: <AANLkTik4_d-QnuQc40JUqtitgsslQqWjF5sPUID7aT1M@mail.gmail.com>
From: Garrett Cooper <yanegomi@gmail.com>
To: hackers@freebsd.org
Content-Type: text/plain; charset=ISO-8859-1
Cc: 
Subject: [PATCH] Use _SIG_VALID macro in lib/libthr/thread/thr_sig.c
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Jul 2010 07:44:49 -0000

    Found another item that could be converted over to _SIG_VALID in
libthr's thr_sig.c this time.
Thanks,
-Garrett

Index: lib/libthr/thread/thr_sig.c
===================================================================
--- lib/libthr/thread/thr_sig.c	(revision 206173)
+++ lib/libthr/thread/thr_sig.c	(working copy)
@@ -194,7 +194,7 @@
 _sigaction(int sig, const struct sigaction * act, struct sigaction * oact)
 {
 	/* Check if the signal number is out of range: */
-	if (sig < 1 || sig > _SIG_MAXSIG || sig == SIGCANCEL) {
+	if (!_SIG_VALID(sig) || sig == SIGCANCEL) {
 		/* Return an invalid argument: */
 		errno = EINVAL;
 		return (-1);