From owner-p4-projects@FreeBSD.ORG  Mon Aug  4 19:37:33 2003
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 54CAD37B404; Mon,  4 Aug 2003 19:37:33 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0C48F37B401
	for <perforce@freebsd.org>; Mon,  4 Aug 2003 19:37:33 -0700 (PDT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A411543F3F
	for <perforce@freebsd.org>; Mon,  4 Aug 2003 19:37:32 -0700 (PDT)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h752bW0U077765
	for <perforce@freebsd.org>; Mon, 4 Aug 2003 19:37:32 -0700 (PDT)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h752bVmC077762
	for perforce@freebsd.org; Mon, 4 Aug 2003 19:37:31 -0700 (PDT)
Date: Mon, 4 Aug 2003 19:37:31 -0700 (PDT)
Message-Id: <200308050237.h752bVmC077762@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	bb+lists.freebsd.perforce@cyrus.watson.org using -f
From: Robert Watson <rwatson@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Subject: PERFORCE change 35509 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Aug 2003 02:37:34 -0000

http://perforce.freebsd.org/chv.cgi?CH=35509

Change 35509 by rwatson@rwatson_tislabs on 2003/08/04 19:36:45

	An XXX on a possibly wrong cred in the NFS code: it's using
	td->td_ucred instead of nd->nd_cr (the NFS credential).

Affected files ...

.. //depot/projects/trustedbsd/mac/sys/nfsserver/nfs_serv.c#26 edit

Differences ...

==== //depot/projects/trustedbsd/mac/sys/nfsserver/nfs_serv.c#26 (text+ko) ====

@@ -1969,6 +1969,9 @@
 		nd.ni_cnd.cn_nameiop = LOOKUP;
 		nd.ni_cnd.cn_flags &= ~(LOCKPARENT);
 		nd.ni_cnd.cn_thread = td;
+		/*
+	 	 * XXXMAC: Wrong cred?
+		 */
 		nd.ni_cnd.cn_cred = td->td_ucred;
 
 		error = lookup(&nd);