From owner-freebsd-net@FreeBSD.ORG  Thu May 30 08:00:02 2013
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id 99D83285
 for <freebsd-net@smarthost.ysv.freebsd.org>;
 Thu, 30 May 2013 08:00:02 +0000 (UTC)
 (envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 8CBC78C0
 for <freebsd-net@smarthost.ysv.freebsd.org>;
 Thu, 30 May 2013 08:00:02 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r4U802CZ090892
 for <freebsd-net@freefall.freebsd.org>; Thu, 30 May 2013 08:00:02 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r4U802sw090891;
 Thu, 30 May 2013 08:00:02 GMT (envelope-from gnats)
Date: Thu, 30 May 2013 08:00:02 GMT
Message-Id: <201305300800.r4U802sw090891@freefall.freebsd.org>
To: freebsd-net@FreeBSD.org
Cc: 
From: Mark Linimon <linimon@lonesome.com>
Subject: Re: kern/179083: [netmap] [patch] Invalid index calucation in netmap
 macro expansion
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: Mark Linimon <linimon@lonesome.com>
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 30 May 2013 08:00:02 -0000

The following reply was made to PR kern/179083; it has been noted by GNATS.

From: Mark Linimon <linimon@lonesome.com>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/179083: [netmap] [patch] Invalid index calucation in netmap
 macro expansion
Date: Thu, 30 May 2013 02:58:04 -0500

 ----- Forwarded message from Luigi Rizzo <rizzo@iet.unipi.it> -----
 
 Date: Thu, 30 May 2013 09:57:15 +0200
 From: Luigi Rizzo <rizzo@iet.unipi.it>
 To: freebsd-bugs@freebsd.org, freebsd-net@freebsd.org
 Subject: Re: kern/179083: [netmap] [patch] Invalid index calucation in netmap macro expansion
 User-Agent: Mutt/1.5.20 (2009-06-14)
 
 Thanks for the report.
 
 The macro is correct as implemented.
 The problem, in case, is in the description in netmap_user.h which
 is confusing and should be improved as follows:
 
 -*      char *buf = NETMAP_BUF(ring, index) returns a pointer to
 -*              the i-th buffer
 +*      char *buf = NETMAP_BUF(ring, x) returns a pointer to
 +*              the buffer numbered 'x'
 
 This will be committed soon, so please close the PR
 
 cheers
 luigi
 
 ----- End forwarded message -----