From owner-freebsd-hackers Tue Dec 12 9:19:25 2000 From owner-freebsd-hackers@FreeBSD.ORG Tue Dec 12 09:19:23 2000 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from rover.village.org (rover.village.org [204.144.255.66]) by hub.freebsd.org (Postfix) with ESMTP id 0720137B400; Tue, 12 Dec 2000 09:19:22 -0800 (PST) Received: from harmony.village.org (harmony.village.org [10.0.0.6]) by rover.village.org (8.11.0/8.11.0) with ESMTP id eBCHIxs74455; Tue, 12 Dec 2000 10:18:59 -0700 (MST) (envelope-from imp@harmony.village.org) Received: from harmony.village.org (localhost.village.org [127.0.0.1]) by harmony.village.org (8.9.3/8.8.3) with ESMTP id KAA30522; Tue, 12 Dec 2000 10:18:59 -0700 (MST) Message-Id: <200012121718.KAA30522@harmony.village.org> To: John Baldwin Subject: Re: Partial start on pci + serial/parallel cards Cc: hackers@FreeBSD.org, Nicolas Souchu In-reply-to: Your message of "Tue, 12 Dec 2000 09:13:07 PST." References: Date: Tue, 12 Dec 2000 10:18:58 -0700 From: Warner Losh Sender: imp@harmony.village.org Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In message John Baldwin writes: : : On 12-Dec-00 Warner Losh wrote: : > In message <20001212100513.B6007@wiliam.alcove-int> Nicolas Souchu writes: : >: > looking at the code. I'd also think about moving it to dev/ppc with a : >: > ppc_isa.c and ppc_puc.c. : >: : >: This is something I don't understand. If ppc_puc is a PCI driver why don't : >: you put in the pci directory and let ppc_isa in isa one? : > : > Because in FreeBSD you put all the files for a driver in one : > directory. In NetBSD you'd do things the way you are talking about. : > sio and ppc break this rule right now. : : ...and npx; fd; joy; psm; various ISA portions of vga, syscons, and atkbd; : intpm; meteor; agp; all the PCI network drivers; etc. :-) Yes. I wasn't planning on moving them. But not all the pci network drivers break this rule. vx, at the minimum, follows the new guidelines. The "common sense rider" on this rule has been don't move anything just to move it. Move it when it makes sense to move it. Many drivers have been moved out of isa/* or i386/isa/* to this new location when they grow another bus attachment (usually for pccard). Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message